netdev - Re: [PATCH net-next 1/3] tcp: remove obsolete and unused RFC3517/RFC6675 loss recovery code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250614130717.40a42cce@kernel.org>
Date: Sat, 14 Jun 2025 13:07:17 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Neal Cardwell <ncardwell.sw@...il.com>
Cc: David Miller <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 netdev@...r.kernel.org, Neal Cardwell <ncardwell@...gle.com>, Yuchung Cheng
 <ycheng@...gle.com>
Subject: Re: [PATCH net-next 1/3] tcp: remove obsolete and unused
 RFC3517/RFC6675 loss recovery code

On Fri, 13 Jun 2025 19:09:04 -0400 Neal Cardwell wrote:
> RACK-TLP loss detection has been enabled as the default loss detection
> algorithm for Linux TCP since 2018, in:
> 
>  commit b38a51fec1c1 ("tcp: disable RFC6675 loss detection")

Hi! There is a warning here:

net/ipv4/tcp_input.c:2959:6: warning: variable 'fast_rexmit' set but not used [-Wunused-but-set-variable]
 2959 |         int fast_rexmit = 0, flag = *ack_flag;
      |             ^

and another one in patch 2:

net/ipv4/tcp_input.c:3367:29: warning: variable ‘delta’ set but not used [-Wunused-but-set-variable]
 3367 |                         int delta;
      |                             ^~~~~
-- 
pw-bot: cr