netdev - Re: [PATCH net-next 1/3] tcp: remove obsolete and unused RFC3517/RFC6675 loss recovery code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CADVnQym21-q9SJbCNZR0qyLJHxCFLYUjSUr4wMyBdVA0TMgjEQ@mail.gmail.com>
Date: Sat, 14 Jun 2025 20:18:04 -0400
From: Neal Cardwell <ncardwell@...gle.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Neal Cardwell <ncardwell.sw@...il.com>, David Miller <davem@...emloft.net>, 
	Eric Dumazet <edumazet@...gle.com>, netdev@...r.kernel.org, 
	Yuchung Cheng <ycheng@...gle.com>
Subject: Re: [PATCH net-next 1/3] tcp: remove obsolete and unused
 RFC3517/RFC6675 loss recovery code

On Sat, Jun 14, 2025 at 4:07 PM Jakub Kicinski <kuba@...nel.org> wrote:
>
> On Fri, 13 Jun 2025 19:09:04 -0400 Neal Cardwell wrote:
> > RACK-TLP loss detection has been enabled as the default loss detection
> > algorithm for Linux TCP since 2018, in:
> >
> >  commit b38a51fec1c1 ("tcp: disable RFC6675 loss detection")
>
> Hi! There is a warning here:
>
> net/ipv4/tcp_input.c:2959:6: warning: variable 'fast_rexmit' set but not used [-Wunused-but-set-variable]
>  2959 |         int fast_rexmit = 0, flag = *ack_flag;
>       |             ^
>
> and another one in patch 2:
>
> net/ipv4/tcp_input.c:3367:29: warning: variable ‘delta’ set but not used [-Wunused-but-set-variable]
>  3367 |                         int delta;
>       |                             ^~~~~

Sorry about that! Sent a v2:

https://lore.kernel.org/netdev/20250615001435.2390793-1-ncardwell.sw@gmail.com/T/#t

thanks,
neal