netdev - Re: [PATCH net-next v2 1/3] vsock: Add support for SIOCINQ ioctl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20250616144200.1187793-1-niuxuewei.nxw@antgroup.com>
Date: Mon, 16 Jun 2025 22:42:00 +0800
From: Xuewei Niu <niuxuewei97@...il.com>
To: leonardi@...hat.com
Cc: davem@...emloft.net,
	fupan.lfp@...group.com,
	jasowang@...hat.com,
	kvm@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	mst@...hat.com,
	netdev@...r.kernel.org,
	niuxuewei.nxw@...group.com,
	niuxuewei97@...il.com,
	pabeni@...hat.com,
	sgarzare@...hat.com,
	stefanha@...hat.com,
	virtualization@...ts.linux.dev,
	xuanzhuo@...ux.alibaba.com
Subject: Re: [PATCH net-next v2 1/3] vsock: Add support for SIOCINQ ioctl

> On Mon, Jun 16, 2025 at 03:42:53PM +0200, Luigi Leonardi wrote:
> >On Fri, Jun 13, 2025 at 11:11:50AM +0800, Xuewei Niu wrote:
> >>This patch adds support for SIOCINQ ioctl, which returns the number of
> >>bytes unread in the socket.
> >>
> >>Signed-off-by: Xuewei Niu <niuxuewei.nxw@...group.com>
> >>---
> >>include/net/af_vsock.h   |  2 ++
> >>net/vmw_vsock/af_vsock.c | 22 ++++++++++++++++++++++
> >>2 files changed, 24 insertions(+)
> >>
> >>diff --git a/include/net/af_vsock.h b/include/net/af_vsock.h
> >>index d56e6e135158..723a886253ba 100644
> >>--- a/include/net/af_vsock.h
> >>+++ b/include/net/af_vsock.h
> >>@@ -171,6 +171,8 @@ struct vsock_transport {
> >>
> >>	/* SIOCOUTQ ioctl */
> >>	ssize_t (*unsent_bytes)(struct vsock_sock *vsk);
> >>+	/* SIOCINQ ioctl */
> >>+	ssize_t (*unread_bytes)(struct vsock_sock *vsk);
> >>
> >>	/* Shutdown. */
> >>	int (*shutdown)(struct vsock_sock *, int);
> >>diff --git a/net/vmw_vsock/af_vsock.c b/net/vmw_vsock/af_vsock.c
> >>index 2e7a3034e965..466b1ebadbbc 100644
> >>--- a/net/vmw_vsock/af_vsock.c
> >>+++ b/net/vmw_vsock/af_vsock.c
> >>@@ -1389,6 +1389,28 @@ static int vsock_do_ioctl(struct socket *sock, unsigned int cmd,
> >>	vsk = vsock_sk(sk);
> >>
> >>	switch (cmd) {
> >>+	case SIOCINQ: {
> >>+		ssize_t n_bytes;
> >>+
> >>+		if (!vsk->transport || !vsk->transport->unread_bytes) {
> >>+			ret = -EOPNOTSUPP;
> >>+			break;
> >>+		}
> >>+
> >>+		if (sock_type_connectible(sk->sk_type) &&
> >>+		    sk->sk_state == TCP_LISTEN) {
> >>+			ret = -EINVAL;
> >>+			break;
> >>+		}
> >>+
> >>+		n_bytes = vsk->transport->unread_bytes(vsk);
> >>+		if (n_bytes < 0) {
> >>+			ret = n_bytes;
> >>+			break;
> >>+		}
> >>+		ret = put_user(n_bytes, arg);
> >>+		break;
> >>+	}
> >>	case SIOCOUTQ: {
> >>		ssize_t n_bytes;
> >>
> >>-- 
> >>2.34.1
> >>
> >
> >Reviewed-by: Luigi Leonardi <leonardi@...hat.com>
> 
> Stefano is totally right, reusing `virtio_transport_unread_bytes` is a 
> good idea.
> 
> nit: commit message should use 'imperative' language [1]. "This patch 
> adds" should be avoided.
> 
> Sorry for the confusion.
> 
> Thanks,
> Luigi
> 
> [1]https://www.kernel.org/doc/html/latest/process/submitting-patches.html#describe-your-changes

Thanks for pointing out. I'll update the commit message following the
guidelines.

Thanks,
Xuewei