netdev - Re: [PATCH RFC v3 6/8] virtio_net: enable gso over UDP tunnel support.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <219613ac-2228-49ea-ba8a-23f54e760634@redhat.com>
Date: Mon, 16 Jun 2025 16:44:01 +0200
From: Paolo Abeni <pabeni@...hat.com>
To: Jason Wang <jasowang@...hat.com>
Cc: netdev@...r.kernel.org, Willem de Bruijn
 <willemdebruijn.kernel@...il.com>, Andrew Lunn <andrew+netdev@...n.ch>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, "Michael S. Tsirkin" <mst@...hat.com>,
 Xuan Zhuo <xuanzhuo@...ux.alibaba.com>, Eugenio Pérez
 <eperezma@...hat.com>, Yuri Benditovich <yuri.benditovich@...nix.com>,
 Akihiko Odaki <akihiko.odaki@...nix.com>
Subject: Re: [PATCH RFC v3 6/8] virtio_net: enable gso over UDP tunnel
 support.

On 6/16/25 5:20 AM, Jason Wang wrote:
> On Thu, Jun 12, 2025 at 6:18 PM Paolo Abeni <pabeni@...hat.com> wrote:
>> On 6/12/25 6:05 AM, Jason Wang wrote:
>>> I wonder why virtio_net_chk_data_valid() is not part of the
>>> virtio_net_hdr_tnl_to_skb().
>>
>> It can't be part of virtio_net_hdr_tnl_to_skb(), as hdr to skb
>> conversion is actually not symmetric with respect to the checksum - only
>> the driver handles DATA_VALID.
>>
>> Tun must not call virtio_net_chk_data_valid()  (or whatever different
>> name will use).
> 
> Note that we've already dealt with this via introducing a boolean
> has_data_valid:
> 
> static inline int virtio_net_hdr_from_skb(const struct sk_buff *skb,
>                                           struct virtio_net_hdr *hdr,
>                                           bool little_endian,
>                                           bool has_data_valid,
>                                           int vlan_hlen)
> 

I'll keep the csum offload function separated, to avoid adding even more
argument to the common helper.

/P