netdev - Re: [RFC PATCH v2 nf-next] selftests: netfilter: Add bridge

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250617113414.GI5000@horms.kernel.org>
Date: Tue, 17 Jun 2025 12:34:14 +0100
From: Simon Horman <horms@...nel.org>
To: Eric Woudstra <ericwouds@...il.com>
Cc: Pablo Neira Ayuso <pablo@...filter.org>,
	Jozsef Kadlecsik <kadlec@...filter.org>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Shuah Khan <shuah@...nel.org>,
	Nikolay Aleksandrov <razor@...ckwall.org>,
	Vladimir Oltean <olteanv@...il.com>,
	netfilter-devel@...r.kernel.org, netdev@...r.kernel.org,
	linux-kselftest@...r.kernel.org
Subject: Re: [RFC PATCH v2 nf-next] selftests: netfilter: Add
 bridge_fastpath.sh

On Tue, Jun 17, 2025 at 08:59:30AM +0200, Eric Woudstra wrote:
> Add a script to test various scenarios where a bridge is involved
> in the fastpath. It runs tests in the forward path, and also in
> a bridged path.
> 
> The setup is similar to a basic home router with multiple lan ports.
> 
> It uses 3 pairs of veth-devices. Each or all pairs can be
> replaced by a pair of real interfaces, interconnected by wire.
> This is necessary to test the behavior when dealing with
> dsa ports, foreign (dsa) ports and switchdev userports that support
> SWITCHDEV_OBJ_ID_PORT_VLAN.
> 
> See the head of the script for a detailed description.
> 
> Run without arguments to perform all tests on veth-devices.
> 
> Signed-off-by: Eric Woudstra <ericwouds@...il.com>

Hi Eric,

If this proposal proceeds could you please consider running shellcheck over
the script and address the warnings it flags produces.

A shellcheck test was recently added to NIPA and we'd like to at least
minimise adding new warnings to the tree.