netdev - Re: [RFC PATCH v2 nf-next] selftests: netfilter: Add bridge

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aFlTNAsZh-g1SvWQ@strlen.de>
Date: Mon, 23 Jun 2025 15:14:28 +0200
From: Florian Westphal <fw@...len.de>
To: Eric Woudstra <ericwouds@...il.com>
Cc: Pablo Neira Ayuso <pablo@...filter.org>,
	Jozsef Kadlecsik <kadlec@...filter.org>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Simon Horman <horms@...nel.org>, Shuah Khan <shuah@...nel.org>,
	Nikolay Aleksandrov <razor@...ckwall.org>,
	Vladimir Oltean <olteanv@...il.com>,
	netfilter-devel@...r.kernel.org, netdev@...r.kernel.org,
	linux-kselftest@...r.kernel.org
Subject: Re: [RFC PATCH v2 nf-next] selftests: netfilter: Add
 bridge_fastpath.sh

Eric Woudstra <ericwouds@...il.com> wrote:
> Without patches:
> 
> PASS:  unaware bridge, without encaps,            without fastpath
> PASS:  unaware bridge, with single vlan encap,    without fastpath
> ERROR: unaware bridge, with double q vlan encaps, without fastpath: ipv4/6: established bytes 0 < 4194304
> ERROR: unaware bridge, with 802.1ad vlan encaps,  without fastpath: ipv4/6: established bytes 0 < 4194304
> PASS:  aware bridge,   without/without vlan encap, without fastpath
> PASS:  aware bridge,   with/without vlan encap,    without fastpath
> PASS:  aware bridge,   with/with vlan encap,       without fastpath
> PASS:  aware bridge,   without/with vlan encap,    without fastpath
> PASS:  forward,        without vlan-device, without vlan encap, client1, without fastpath
> PASS:  forward,        without vlan-device, without vlan encap, client1, with fastpath
> PASS:  forward,        without vlan-device, with vlan encap,    client1, without fastpath
> ERROR: forward,        without vlan-device, with vlan encap,    client1, with fastpath: ipv4/6: tcp broken
> PASS:  forward,        with vlan-device,    with vlan encap,    client1, without fastpath
> PASS:  forward,        with vlan-device,    with vlan encap,    client1, with fastpath
> PASS:  forward,        with vlan-device,    without vlan encap, client1, without fastpath
> PASS:  forward,        with vlan-device,    without vlan encap, client1, with fastpath
> ERROR: bridge fastpath test has failed

Would you mind sending a version without RFC tag that passes
without any of the patches?

I'll leave it up to you if you prefer to remove the subtests
that don't work without your changes or downgrade them to
a SKIP or similar.

That way, at least this patch could be applied.  And I think we
can all agree that it would be good to have it in-tree.