netdev - Re: [PATCH net-next] dpaa_eth: don't use fixed_phy_change

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2f590e74-4aca-4064-8226-378eed481ded@intel.com>
Date: Tue, 17 Jun 2025 09:58:28 -0700
From: Jacob Keller <jacob.e.keller@...el.com>
To: Andrew Lunn <andrew@...n.ch>
CC: Heiner Kallweit <hkallweit1@...il.com>, Andrew Lunn
	<andrew+netdev@...n.ch>, Paolo Abeni <pabeni@...hat.com>, Jakub Kicinski
	<kuba@...nel.org>, David Miller <davem@...emloft.net>, Eric Dumazet
	<edumazet@...gle.com>, Simon Horman <horms@...nel.org>, Madalin Bucur
	<madalin.bucur@....com>, Russell King - ARM Linux <linux@...linux.org.uk>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>, Joakim Tjernlund
	<joakim.tjernlund@...inera.com>
Subject: Re: [PATCH net-next] dpaa_eth: don't use fixed_phy_change_carrier



On 6/16/2025 4:44 PM, Andrew Lunn wrote:
> On Mon, Jun 16, 2025 at 03:47:57PM -0700, Jacob Keller wrote:
>>
>>
>> On 6/16/2025 2:24 PM, Heiner Kallweit wrote:
>>> This effectively reverts 6e8b0ff1ba4c ("dpaa_eth: Add change_carrier()
>>> for Fixed PHYs"). Usage of fixed_phy_change_carrier() requires that
>>> fixed_phy_register() has been called before, directly or indirectly.
>>> And that's not the case in this driver.
>>>
>>> Signed-off-by: Heiner Kallweit <hkallweit1@...il.com>
>>> ---
>>
>> Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>
>>
>> Is this harmful to leave set if fixed_phy_register() is not called? If
>> so then this could be net + a fixes tag instead of net-next.
> 
> It appears to be used if you echo something to
> /sys/class/net/eth42/carrier. It will return EINVAL.
> 
> The same will happen if you use do_set_proto_down() via rtnetlink.
> 
> Apart from the EINVAL returned to userspace, nothing bad will happen.
> So i don't think this needs a Fixes: tag.
> 
> 	Andrew

Thanks! Makes sense to keep it as a net-next cleanup then.