netdev - Re: [PATCH net-next] ipv6: Simplify link-local address generation for IPv6 GRE.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aFGbyuXocIo3ejFC@shredder>
Date: Tue, 17 Jun 2025 19:46:02 +0300
From: Ido Schimmel <idosch@...sch.org>
To: Guillaume Nault <gnault@...hat.com>
Cc: David Miller <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>,
	Paolo Abeni <pabeni@...hat.com>, Eric Dumazet <edumazet@...gle.com>,
	netdev@...r.kernel.org, Simon Horman <horms@...nel.org>,
	David Ahern <dsahern@...nel.org>
Subject: Re: [PATCH net-next] ipv6: Simplify link-local address generation
 for IPv6 GRE.

On Mon, Jun 16, 2025 at 01:58:29PM +0200, Guillaume Nault wrote:
> Since commit 3e6a0243ff00 ("gre: Fix again IPv6 link-local address
> generation."), addrconf_gre_config() has stopped handling IP6GRE
> devices specially and just calls the regular addrconf_addr_gen()
> function to create their link-local IPv6 addresses.
> 
> We can thus avoid using addrconf_gre_config() for IP6GRE devices and
> use the normal IPv6 initialisation path instead (that is, jump directly
> to addrconf_dev_config() in addrconf_init_auto_addrs()).
> 
> See commit 3e6a0243ff00 ("gre: Fix again IPv6 link-local address
> generation.") for a deeper explanation on how and why GRE devices
> started handling their IPv6 link-local address generation specially,
> why it was a problem, and why this is not even necessary in most cases
> (especially for GRE over IPv6).
> 
> Signed-off-by: Guillaume Nault <gnault@...hat.com>

Reviewed-by: Ido Schimmel <idosch@...dia.com>