netdev - Re: [PATCH net-next v2] net: lan743x: fix potential out-of-bounds write in lan743x_ptp_io_event_clock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f343fc9d-b3a3-4dbb-9a9c-242b7b79b97d@redhat.com>
Date: Thu, 19 Jun 2025 12:26:22 +0200
From: Paolo Abeni <pabeni@...hat.com>
To: Alexey Kodanev <aleksei.kodanev@...l-sw.com>, netdev@...r.kernel.org,
 Bryan Whitehead <bryan.whitehead@...rochip.com>
Cc: UNGLinuxDriver@...rochip.com,
 Raju Lakkaraju <Raju.Lakkaraju@...rochip.com>,
 Andrew Lunn <andrew+netdev@...n.ch>, "David S . Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Richard Cochran
 <richardcochran@...il.com>, Rengarajan.S@...rochip.com
Subject: Re: [PATCH net-next v2] net: lan743x: fix potential out-of-bounds
 write in lan743x_ptp_io_event_clock_get()

On 6/19/25 12:04 PM, Paolo Abeni wrote:
> On 6/16/25 1:37 PM, Alexey Kodanev wrote:
>> Before calling lan743x_ptp_io_event_clock_get(), the 'channel' value
>> is checked against the maximum value of PCI11X1X_PTP_IO_MAX_CHANNELS(8).
>> This seems correct and aligns with the PTP interrupt status register
>> (PTP_INT_STS) specifications.
>>
>> However, lan743x_ptp_io_event_clock_get() writes to ptp->extts[] with
>> only LAN743X_PTP_N_EXTTS(4) elements, using channel as an index:
>>
>>     lan743x_ptp_io_event_clock_get(..., u8 channel,...)
>>     {
>>         ...
>>         /* Update Local timestamp */
>>         extts = &ptp->extts[channel];
>>         extts->ts.tv_sec = sec;
>>         ...
>>     }
>>
>> To avoid an out-of-bounds write and utilize all the supported GPIO
>> inputs, set LAN743X_PTP_N_EXTTS to 8.
>>
>> Detected using the static analysis tool - Svace.
>> Fixes: 60942c397af6 ("net: lan743x: Add support for PTP-IO Event Input External Timestamp (extts)")
>> Signed-off-by: Alexey Kodanev <aleksei.kodanev@...l-sw.com>
> 
> @Rengarajan: I see you suggested this approach on V1, but it would be
> nice to have explicit ack here (or even better in this case tested-by)

Rengarajan email address is bouncing. @Bryan: same request as above for
you (or any other person @microchip).

Thanks,

Paolo