netdev - Re: [PATCH v1 net-next 02/15] ipv6: mcast: Replace locking comments with lockdep annotations.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7f2ac806-d033-44de-9241-e5a3194dd729@redhat.com>
Date: Thu, 19 Jun 2025 13:56:26 +0200
From: Paolo Abeni <pabeni@...hat.com>
To: Kuniyuki Iwashima <kuni1840@...il.com>,
 "David S. Miller" <davem@...emloft.net>, David Ahern <dsahern@...nel.org>,
 Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>
Cc: Simon Horman <horms@...nel.org>, Kuniyuki Iwashima <kuniyu@...gle.com>,
 netdev@...r.kernel.org
Subject: Re: [PATCH v1 net-next 02/15] ipv6: mcast: Replace locking comments
 with lockdep annotations.

On 6/17/25 1:28 AM, Kuniyuki Iwashima wrote:
> @@ -2072,10 +2086,7 @@ static void mld_send_report(struct inet6_dev *idev, struct ifmcaddr6 *pmc)
>  		mld_sendpack(skb);
>  }
>  
> -/*
> - * remove zero-count source records from a source filter list
> - * called with mc_lock
> - */
> +/* remove zero-count source records from a source filter list */
>  static void mld_clear_zeros(struct ip6_sf_list __rcu **ppsf, struct inet6_dev *idev)
>  {
>  	struct ip6_sf_list *psf_prev, *psf_next, *psf;
> @@ -2099,7 +2110,6 @@ static void mld_clear_zeros(struct ip6_sf_list __rcu **ppsf, struct inet6_dev *i
>  	}
>  }
>  
> -/* called with mc_lock */
>  static void mld_send_cr(struct inet6_dev *idev)
>  {
>  	struct ifmcaddr6 *pmc, *pmc_prev, *pmc_next;

Why are you not adding the annotation in the above 2 places? AFAICS
mld_send_cr() is called only by mld_ifc_work(), after acquiring the
relevant lock, and mld_clear_zeros() is only called by mld_send_cr(),
still under the same lock.

/P