netdev - Re: [PATCH] can: rcar_canfd: Describe channel-specific FD registers using C struct

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMuHMdVKx7+errmKfzEZmuan0sRFw0-NXEORtntfyksgpAy8_g@mail.gmail.com>
Date: Thu, 19 Jun 2025 13:56:40 +0200
From: Geert Uytterhoeven <geert@...ux-m68k.org>
To: Vincent Mailhol <mailhol.vincent@...adoo.fr>
Cc: Jakub Kicinski <kuba@...nel.org>, Biju Das <biju.das.jz@...renesas.com>, 
	linux-can@...r.kernel.org, netdev@...r.kernel.org, 
	linux-renesas-soc@...r.kernel.org, Marc Kleine-Budde <mkl@...gutronix.de>, 
	"David S . Miller" <davem@...emloft.net>
Subject: Re: [PATCH] can: rcar_canfd: Describe channel-specific FD registers
 using C struct

Hi Vincent,

On Thu, 19 Jun 2025 at 13:12, Vincent Mailhol
<mailhol.vincent@...adoo.fr> wrote:
> On 19/06/2025 at 19:13, Geert Uytterhoeven wrote:
> > The rcar_canfd_f_*() inline functions to obtain channel-specific CAN-FD
> > register offsets really describe a memory layout.  Hence replace them by
> > a C structure, to simplify the code, and reduce kernel size.
> >
> > This also gets rid of warnings about unused rcar_canfd_f_*() inline
> > functions, which are reported by recent versions of clang.
> >
> > Suggested-by: Vincent Mailhol <mailhol.vincent@...adoo.fr>
> > Reported-by: Jakub Kicinski <kuba@...nel.org>
> > Closes: https://lore.kernel.org/20250618183827.5bebca8f@kernel.org
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>
> > ---
> > Fast-tracked because of the clang warnings.
>
> Make sense.
>
> @Jakub, OK for me if you want to directly pick this patch without going through
> the linux-can tree.
>
> > Changes compared to Vincent's original suggestion
> > (https://lore.kernel.org/420d37b1-5648-4209-8d6f-1ac9d780eea2@wanadoo.fr):
> >   - Move rcar_canfd_f to the old RCANFD_F_*() location,
> >   - Update RSCFDnCFDCmXXX comment.
> >   - Rename struct rcar_canfd_f to struct rcar_canfd_f,
>                                            ^^^^^^^^^^^^
> rcar_canfd_f_c ;)

Oops, right...

> >   - Rename cbase to fcbase,
> >   - Drop static_assert(),
> >   - Drop unused car_canfd_*_reg() functions.
> >   - Drop simple wrappers around {read,write}l(),
>
> Acked-by: Vincent Mailhol <mailhol.vincent@...adoo.fr>

Thanks!

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds