netdev - Re: [PATCH net-next 0/8] net: maintain netif vs dev prefix semantics

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6859bbade00da_101e05294a7@willemb.c.googlers.com.notmuch>
Date: Mon, 23 Jun 2025 16:40:13 -0400
From: Willem de Bruijn <willemdebruijn.kernel@...il.com>
To: Stanislav Fomichev <sdf@...ichev.me>, 
 netdev@...r.kernel.org
Cc: davem@...emloft.net, 
 edumazet@...gle.com, 
 kuba@...nel.org, 
 pabeni@...hat.com
Subject: Re: [PATCH net-next 0/8] net: maintain netif vs dev prefix semantics

Stanislav Fomichev wrote:
> Commit cc34acd577f1 ("docs: net: document new locking reality")
> introduced netif_ vs dev_ function semantics: the former expects locked
> netdev, the latter takes care of the locking. We don't strictly
> follow this semantics on either side, but there are more dev_xxx handlers
> now that don't fit. Rename them to netif_xxx where appropriate. We care only
> about driver-visible APIs, don't touch stack-internal routines.
> 
> This is part 1, I'm considering following up with these (haven't looked
> deep, maybe the ones that are frequently used are fine to keep):
> 
>   * dev_get_tstats64 dev_fetch_sw_netstats
>   * dev_xdp_prog_count,
>   * dev_add_pack dev_remove_pack dev_remove_pack
>   * dev_get_iflink
>   * dev_fill_forward_path
>   * dev_getbyhwaddr_rcu dev_getbyhwaddr dev_getfirstbyhwtype
>   * dev_valid_name dev_valid_name
>   * dev_forward dev_forward_skb
>   * dev_queue_xmit_nit dev_nit_active_rcu
>   * dev_pick_tx_zero
> 
> Sending this out to get a sense of direction :-)
> 
> Stanislav Fomichev (8):
>   net: s/dev_get_stats/netif_get_stats/
>   net: s/dev_get_port_parent_id/netif_get_port_parent_id/
>   net: s/dev_get_mac_address/netif_get_mac_address/
>   net: s/dev_pre_changeaddr_notify/netif_pre_changeaddr_notify/
>   net: s/__dev_set_mtu/__netif_set_mtu/
>   net: s/dev_get_flags/netif_get_flags/
>   net: s/dev_set_threaded/netif_set_threaded/
>   net: s/dev_close_many/netif_close_many/

Maybe also an opportunity to move the modified EXPORT_SYMBOL_GPL
into the NETDEV_INTERNAL namespace?

Context in commit 0b7bdc7fab57 ("netdev: define NETDEV_INTERNAL")