netdev - Re: [PATCH net 08/10] netlink: specs: rt-link: replace underscores with dashes in names

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5eca05e7-59e3-4b23-8be3-aaf796c856a3@intel.com>
Date: Tue, 24 Jun 2025 15:33:49 -0700
From: Jacob Keller <jacob.e.keller@...el.com>
To: Jakub Kicinski <kuba@...nel.org>, <davem@...emloft.net>,
	<donald.hunter@...il.com>
CC: <netdev@...r.kernel.org>, <edumazet@...gle.com>, <pabeni@...hat.com>,
	<andrew+netdev@...n.ch>, <horms@...nel.org>
Subject: Re: [PATCH net 08/10] netlink: specs: rt-link: replace underscores
 with dashes in names



On 6/24/2025 2:10 PM, Jakub Kicinski wrote:
> We're trying to add a strict regexp for the name format in the spec.
> Underscores will not be allowed, dashes should be used instead.
> This makes no difference to C (codegen, if used, replaces special
> chars in names) but it gives more uniform naming in Python.
> 
> Fixes: b2f63d904e72 ("doc/netlink: Add spec for rt link messages")
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> ---
> CC: donald.hunter@...il.com
> CC: jacob.e.keller@...el.com
> ---
>  Documentation/netlink/specs/rt-link.yaml | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/netlink/specs/rt-link.yaml b/Documentation/netlink/specs/rt-link.yaml
> index b41b31eebcae..28c4cf66517c 100644
> --- a/Documentation/netlink/specs/rt-link.yaml
> +++ b/Documentation/netlink/specs/rt-link.yaml
> @@ -603,7 +603,7 @@ protonum: 0
>          name: optmask
>          type: u32
>    -
> -    name: if_stats_msg
> +    name: if-stats-msg
>      type: struct
>      members:
>        -
> @@ -2486,7 +2486,7 @@ protonum: 0
>        name: getstats
>        doc: Get / dump link stats.
>        attribute-set: stats-attrs
> -      fixed-header: if_stats_msg
> +      fixed-header: if-stats-msg
>        do:
>          request:
>            value: 94

Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>