netdev - Re: [PATCH net 05/10] netlink: specs: devlink: replace underscores with dashes in names

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cd8e05e6-76e8-4fa7-89d5-33b1c4f7359e@intel.com>
Date: Tue, 24 Jun 2025 15:34:23 -0700
From: Jacob Keller <jacob.e.keller@...el.com>
To: Jakub Kicinski <kuba@...nel.org>, <davem@...emloft.net>,
	<donald.hunter@...il.com>
CC: <netdev@...r.kernel.org>, <edumazet@...gle.com>, <pabeni@...hat.com>,
	<andrew+netdev@...n.ch>, <horms@...nel.org>, <jiri@...nulli.us>,
	<kalesh-anakkur.purayil@...adcom.com>, <saeedm@...dia.com>
Subject: Re: [PATCH net 05/10] netlink: specs: devlink: replace underscores
 with dashes in names



On 6/24/2025 2:09 PM, Jakub Kicinski wrote:
> We're trying to add a strict regexp for the name format in the spec.
> Underscores will not be allowed, dashes should be used instead.
> This makes no difference to C (codegen, if used, replaces special
> chars in names) but it gives more uniform naming in Python.
> 
> Fixes: 429ac6211494 ("devlink: define enum for attr types of dynamic attributes")
> Fixes: f2f9dd164db0 ("netlink: specs: devlink: add the remaining command to generate complete split_ops")
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> ---
> CC: donald.hunter@...il.com
> CC: jiri@...nulli.us
> CC: kalesh-anakkur.purayil@...adcom.com
> CC: saeedm@...dia.com
> CC: jacob.e.keller@...el.com
> ---
>  Documentation/netlink/specs/devlink.yaml | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/Documentation/netlink/specs/devlink.yaml b/Documentation/netlink/specs/devlink.yaml
> index 05fee1b7fe19..38ddc04f9e6d 100644
> --- a/Documentation/netlink/specs/devlink.yaml
> +++ b/Documentation/netlink/specs/devlink.yaml
> @@ -38,15 +38,15 @@ doc: Partial family for Devlink.
>        -
>          name: dsa
>        -
> -        name: pci_pf
> +        name: pci-pf
>        -
> -        name: pci_vf
> +        name: pci-vf
>        -
>          name: virtual
>        -
>          name: unused
>        -
> -        name: pci_sf
> +        name: pci-sf
>    -
>      type: enum
>      name: port-fn-state
> @@ -220,7 +220,7 @@ doc: Partial family for Devlink.
>        -
>          name: flag
>        -
> -        name: nul_string
> +        name: nul-string
>          value: 10
>        -
>          name: binary


Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>