netdev - Re: [PATCH net 04/10] netlink: specs: dpll: replace underscores with dashes in names

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d20c4397-0d77-4053-8ff7-cb9af2d16ade@linux.dev>
Date: Tue, 24 Jun 2025 23:58:31 +0100
From: Vadim Fedorenko <vadim.fedorenko@...ux.dev>
To: Jakub Kicinski <kuba@...nel.org>, davem@...emloft.net,
 donald.hunter@...il.com
Cc: netdev@...r.kernel.org, edumazet@...gle.com, pabeni@...hat.com,
 andrew+netdev@...n.ch, horms@...nel.org, jiri@...nulli.us,
 arkadiusz.kubalewski@...el.com, aleksandr.loktionov@...el.com,
 michal.michalik@...el.com
Subject: Re: [PATCH net 04/10] netlink: specs: dpll: replace underscores with
 dashes in names

On 24/06/2025 22:09, Jakub Kicinski wrote:
> We're trying to add a strict regexp for the name format in the spec.
> Underscores will not be allowed, dashes should be used instead.
> This makes no difference to C (codegen, if used, replaces special
> chars in names) but it gives more uniform naming in Python.
> 
> Fixes: 3badff3a25d8 ("dpll: spec: Add Netlink spec in YAML")
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> ---
> CC: donald.hunter@...il.com
> CC: jiri@...nulli.us
> CC: arkadiusz.kubalewski@...el.com
> CC: aleksandr.loktionov@...el.com
> CC: michal.michalik@...el.com
> CC: vadim.fedorenko@...ux.dev
> ---
>   Documentation/netlink/specs/dpll.yaml | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/netlink/specs/dpll.yaml b/Documentation/netlink/specs/dpll.yaml
> index 8feefeae5376..f434140b538e 100644
> --- a/Documentation/netlink/specs/dpll.yaml
> +++ b/Documentation/netlink/specs/dpll.yaml
> @@ -188,7 +188,7 @@ doc: DPLL subsystem.
>       value: 10000
>     -
>       type: const
> -    name: pin-frequency-77_5-khz
> +    name: pin-frequency-77-5-khz
>       value: 77500
>     -
>       type: const

Reviewed-by: Vadim Fedorenko <vadim.fedorenko@...ux.dev>