netdev - Re: [PATCH net 10/10] netlink: specs: enforce strict naming of properties

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <m2ldpgb0gr.fsf@gmail.com>
Date: Wed, 25 Jun 2025 11:05:24 +0100
From: Donald Hunter <donald.hunter@...il.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net,  netdev@...r.kernel.org,  edumazet@...gle.com,
  pabeni@...hat.com,  andrew+netdev@...n.ch,  horms@...nel.org
Subject: Re: [PATCH net 10/10] netlink: specs: enforce strict naming of
 properties

Jakub Kicinski <kuba@...nel.org> writes:

> Add a regexp to make sure all names which may end up being visible
> to the user consist of lower case characters, numbers and dashes.
> Underscores keep sneaking into the specs, which is not visible
> in the C code but makes the Python and alike inconsistent.
>
> Note that starting with a number is okay, as in C the full
> name will include the family name.
>
> For legacy families we can't enforce the naming in the family
> name or the multicast group names, as these are part of the
> binary uAPI of the kernel.
>
> For classic netlink we need to allow capital letters in names
> of struct members. TC has some structs with capitalized members.
>
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>

Reviewed-by: Donald Hunter <donald.hunter@...il.com>