netdev - Re: [PATCH net 06/10] netlink: specs: ovs_flow: replace underscores with dashes in names

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2026a8ac-5e2a-4852-b7da-1f07ff916766@ovn.org>
Date: Wed, 25 Jun 2025 12:15:25 +0200
From: Ilya Maximets <i.maximets@....org>
To: Jakub Kicinski <kuba@...nel.org>, davem@...emloft.net,
 donald.hunter@...il.com
Cc: i.maximets@....org, netdev@...r.kernel.org, edumazet@...gle.com,
 pabeni@...hat.com, andrew+netdev@...n.ch, horms@...nel.org,
 amorenoz@...hat.com, echaudro@...hat.com, michal.kubiak@...el.com
Subject: Re: [PATCH net 06/10] netlink: specs: ovs_flow: replace underscores
 with dashes in names

On 6/24/25 11:09 PM, Jakub Kicinski wrote:
> We're trying to add a strict regexp for the name format in the spec.
> Underscores will not be allowed, dashes should be used instead.
> This makes no difference to C (codegen, if used, replaces special
> chars in names) but it gives more uniform naming in Python.
> 
> Fixes: 93b230b549bc ("netlink: specs: add ynl spec for ovs_flow")
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> ---
> CC: donald.hunter@...il.com
> CC: i.maximets@....org
> CC: amorenoz@...hat.com
> CC: echaudro@...hat.com
> CC: michal.kubiak@...el.com
> ---
>  Documentation/netlink/specs/ovs_flow.yaml | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/netlink/specs/ovs_flow.yaml b/Documentation/netlink/specs/ovs_flow.yaml
> index 46f5d1cd8a5f..7974aa7d8905 100644
> --- a/Documentation/netlink/specs/ovs_flow.yaml
> +++ b/Documentation/netlink/specs/ovs_flow.yaml
> @@ -216,7 +216,7 @@ uapi-header: linux/openvswitch.h
>      type: struct
>      members:
>        -
> -        name: nd_target
> +        name: nd-target
>          type: binary
>          len: 16
>          byte-order: big-endian
> @@ -258,12 +258,12 @@ uapi-header: linux/openvswitch.h
>      type: struct
>      members:
>        -
> -        name: vlan_tpid
> +        name: vlan-tpid
>          type: u16
>          byte-order: big-endian
>          doc: Tag protocol identifier (TPID) to push.
>        -
> -        name: vlan_tci
> +        name: vlan-tci
>          type: u16
>          byte-order: big-endian
>          doc: Tag control identifier (TCI) to push.

This makes naming consistent across the attributes, which is good.

Reviewed-by: Ilya Maximets <i.maximets@....org>