netdev - Re: [PATCH net 06/10] netlink: specs: ovs_flow: replace underscores with dashes in names

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <44E2B1F8-7711-437D-8CA1-2ADF5D344356@redhat.com>
Date: Wed, 25 Jun 2025 13:21:29 +0200
From: Eelco Chaudron <echaudro@...hat.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, donald.hunter@...il.com, netdev@...r.kernel.org,
 edumazet@...gle.com, pabeni@...hat.com, andrew+netdev@...n.ch,
 horms@...nel.org, i.maximets@....org, amorenoz@...hat.com,
 michal.kubiak@...el.com
Subject: Re: [PATCH net 06/10] netlink: specs: ovs_flow: replace underscores
 with dashes in names



On 24 Jun 2025, at 23:09, Jakub Kicinski wrote:

> We're trying to add a strict regexp for the name format in the spec.
> Underscores will not be allowed, dashes should be used instead.
> This makes no difference to C (codegen, if used, replaces special
> chars in names) but it gives more uniform naming in Python.
>
> Fixes: 93b230b549bc ("netlink: specs: add ynl spec for ovs_flow")
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> ---
> CC: donald.hunter@...il.com
> CC: i.maximets@....org
> CC: amorenoz@...hat.com
> CC: echaudro@...hat.com
> CC: michal.kubiak@...el.com
> ---

The change makes sense to me.

Reviewed-by: Eelco Chaudron <echaudro@...hat.com>