netdev - Re: [PATCH net-next] selftests: forwarding: lib: Split setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: 
 <175098602599.1388943.17204976288506235120.git-patchwork-notify@kernel.org>
Date: Fri, 27 Jun 2025 01:00:25 +0000
From: patchwork-bot+netdevbpf@...nel.org
To: Petr Machata <petrm@...dia.com>
Cc: davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
 pabeni@...hat.com, netdev@...r.kernel.org, horms@...nel.org,
 idosch@...dia.com, mlxsw@...dia.com, shuah@...nel.org, matttbe@...nel.org,
 linux-kselftest@...r.kernel.org
Subject: Re: [PATCH net-next] selftests: forwarding: lib: Split setup_wait()

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@...nel.org>:

On Wed, 25 Jun 2025 12:41:23 +0200 you wrote:
> setup_wait() takes an optional argument and then is called from the top
> level of the test script. That confuses shellcheck, which thinks that maybe
> the intention is to pass $1 of the script to the function, which is never
> the case. To avoid having to annotate every single new test with a SC
> disable, split the function in two: one that takes a mandatory argument,
> and one that takes no argument at all.
> 
> [...]

Here is the summary with links:
  - [net-next] selftests: forwarding: lib: Split setup_wait()
    https://git.kernel.org/netdev/net-next/c/b7863babce0a

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html