netdev - Re: [PATCH net-next v11 2/8] devlink: Extend devlink rate API with traffic classes bandwidth management

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250626180102.497e35a2@kernel.org>
Date: Thu, 26 Jun 2025 18:01:02 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Mark Bloch <mbloch@...dia.com>
Cc: "David S. Miller" <davem@...emloft.net>, Paolo Abeni
 <pabeni@...hat.com>, Eric Dumazet <edumazet@...gle.com>, "Andrew Lunn"
 <andrew+netdev@...n.ch>, Simon Horman <horms@...nel.org>,
 <saeedm@...dia.com>, <gal@...dia.com>, <leonro@...dia.com>,
 <tariqt@...dia.com>, Donald Hunter <donald.hunter@...il.com>, Jiri Pirko
 <jiri@...nulli.us>, Jonathan Corbet <corbet@....net>, Leon Romanovsky
 <leon@...nel.org>, Chuck Lever <chuck.lever@...cle.com>, Jeff Layton
 <jlayton@...nel.org>, NeilBrown <neil@...wn.name>, Olga Kornievskaia
 <okorniev@...hat.com>, Dai Ngo <Dai.Ngo@...cle.com>, Tom Talpey
 <tom@...pey.com>, Shuah Khan <shuah@...nel.org>, <netdev@...r.kernel.org>,
 <linux-kernel@...r.kernel.org>, <linux-doc@...r.kernel.org>,
 <linux-rdma@...r.kernel.org>, <linux-nfs@...r.kernel.org>,
 <linux-kselftest@...r.kernel.org>, Carolina Jubran <cjubran@...dia.com>,
 Cosmin Ratiu <cratiu@...dia.com>, Jiri Pirko <jiri@...dia.com>
Subject: Re: [PATCH net-next v11 2/8] devlink: Extend devlink rate API with
 traffic classes bandwidth management

On Wed, 25 Jun 2025 21:30:12 +0300 Mark Bloch wrote:
> Introduce support for specifying relative bandwidth shares between
> traffic classes (TC) in the devlink-rate API. This new option allows
> users to allocate bandwidth across multiple traffic classes in a
> single command.

net/devlink/rate.c:390:33: warning: variable 'total' set but not used [-Wunused-but-set-variable]
  390 |         int rem, err = -EOPNOTSUPP, i, total = 0;
      |                                        ^

Documentation/netlink/specs/devlink.yaml
  1277:8    error    wrong indentation: expected 8 but found 7  (indentation)
  1279:8    error    wrong indentation: expected 8 but found 7  (indentation)
-- 
pw-bot: cr