netdev - Re: [PATCH net-next 3/5] eth: mlx5: migrate to the *_rxfh

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0493c69f-b07b-4888-a8e4-fb7f5d5c12fb@nvidia.com>
Date: Mon, 30 Jun 2025 19:58:07 +0300
From: Gal Pressman <gal@...dia.com>
To: Jakub Kicinski <kuba@...nel.org>, davem@...emloft.net
Cc: netdev@...r.kernel.org, edumazet@...gle.com, pabeni@...hat.com,
 andrew+netdev@...n.ch, horms@...nel.org, andrew@...n.ch,
 przemyslaw.kitszel@...el.com, anthony.l.nguyen@...el.com,
 sgoutham@...vell.com, gakula@...vell.com, sbhatta@...vell.com,
 bbhushan2@...vell.com, tariqt@...dia.com, mbloch@...dia.com,
 leon@...nel.org, ecree.xilinx@...il.com
Subject: Re: [PATCH net-next 3/5] eth: mlx5: migrate to the *_rxfh_context ops

On 30/06/2025 19:09, Jakub Kicinski wrote:
> Convert mlx5 to dedicated RXFH ops. This is a fairly shallow
> conversion, TBH, most of the driver code stays as is, but we
> let the core allocate the context ID for the driver.
> 
> Tested with drivers/net/hw/rss_ctx.py on MCX6.
> 
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>

FWIW, I started doing this a while ago and then got distracted by
implementing the netlink counterpart of set rxfh (code is slowly going
through internal review), so a welcome change, thanks!

Also, the ethtool ioctl set_rxfh() function was a nightmare, so its
simplification in this series is a great change.