netdev - Re: [PATCH net-next 4/5] net: ethtool: remove the compat code for _rxfh

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202507011009.04sxbKvR-lkp@intel.com>
Date: Tue, 1 Jul 2025 10:13:43 +0800
From: kernel test robot <lkp@...el.com>
To: Jakub Kicinski <kuba@...nel.org>, davem@...emloft.net
Cc: oe-kbuild-all@...ts.linux.dev, netdev@...r.kernel.org,
	edumazet@...gle.com, pabeni@...hat.com, andrew+netdev@...n.ch,
	horms@...nel.org, andrew@...n.ch, przemyslaw.kitszel@...el.com,
	anthony.l.nguyen@...el.com, sgoutham@...vell.com,
	gakula@...vell.com, sbhatta@...vell.com, bbhushan2@...vell.com,
	tariqt@...dia.com, mbloch@...dia.com, leon@...nel.org,
	gal@...dia.com, ecree.xilinx@...il.com,
	Jakub Kicinski <kuba@...nel.org>
Subject: Re: [PATCH net-next 4/5] net: ethtool: remove the compat code for
 _rxfh_context ops

Hi Jakub,

kernel test robot noticed the following build warnings:

[auto build test WARNING on net-next/main]

url:    https://github.com/intel-lab-lkp/linux/commits/Jakub-Kicinski/eth-otx2-migrate-to-the-_rxfh_context-ops/20250701-002143
base:   net-next/main
patch link:    https://lore.kernel.org/r/20250630160953.1093267-5-kuba%40kernel.org
patch subject: [PATCH net-next 4/5] net: ethtool: remove the compat code for _rxfh_context ops
config: arm-randconfig-r072-20250701 (https://download.01.org/0day-ci/archive/20250701/202507011009.04sxbKvR-lkp@intel.com/config)
compiler: arm-linux-gnueabi-gcc (GCC) 13.3.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250701/202507011009.04sxbKvR-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202507011009.04sxbKvR-lkp@intel.com/

All warnings (new ones prefixed by >>):

   net/core/dev.c: In function 'netdev_rss_contexts_free':
>> net/core/dev.c:11981:43: warning: variable 'rxfh' set but not used [-Wunused-but-set-variable]
   11981 |                 struct ethtool_rxfh_param rxfh;
         |                                           ^~~~


vim +/rxfh +11981 net/core/dev.c

^1da177e4c3f41 Linus Torvalds 2005-04-16  11973  
6ad2962f8adfd5 Edward Cree    2024-06-27  11974  static void netdev_rss_contexts_free(struct net_device *dev)
6ad2962f8adfd5 Edward Cree    2024-06-27  11975  {
6ad2962f8adfd5 Edward Cree    2024-06-27  11976  	struct ethtool_rxfh_context *ctx;
6ad2962f8adfd5 Edward Cree    2024-06-27  11977  	unsigned long context;
6ad2962f8adfd5 Edward Cree    2024-06-27  11978  
87925151191b64 Edward Cree    2024-06-27  11979  	mutex_lock(&dev->ethtool->rss_lock);
6ad2962f8adfd5 Edward Cree    2024-06-27  11980  	xa_for_each(&dev->ethtool->rss_ctx, context, ctx) {
6ad2962f8adfd5 Edward Cree    2024-06-27 @11981  		struct ethtool_rxfh_param rxfh;
6ad2962f8adfd5 Edward Cree    2024-06-27  11982  
6ad2962f8adfd5 Edward Cree    2024-06-27  11983  		rxfh.indir = ethtool_rxfh_context_indir(ctx);
6ad2962f8adfd5 Edward Cree    2024-06-27  11984  		rxfh.key = ethtool_rxfh_context_key(ctx);
6ad2962f8adfd5 Edward Cree    2024-06-27  11985  		rxfh.hfunc = ctx->hfunc;
6ad2962f8adfd5 Edward Cree    2024-06-27  11986  		rxfh.input_xfrm = ctx->input_xfrm;
6ad2962f8adfd5 Edward Cree    2024-06-27  11987  		rxfh.rss_context = context;
6ad2962f8adfd5 Edward Cree    2024-06-27  11988  		rxfh.rss_delete = true;
6ad2962f8adfd5 Edward Cree    2024-06-27  11989  
6ad2962f8adfd5 Edward Cree    2024-06-27  11990  		xa_erase(&dev->ethtool->rss_ctx, context);
122f0aaf307490 Jakub Kicinski 2025-06-30  11991  		dev->ethtool_ops->remove_rxfh_context(dev, ctx, context, NULL);
6ad2962f8adfd5 Edward Cree    2024-06-27  11992  		kfree(ctx);
6ad2962f8adfd5 Edward Cree    2024-06-27  11993  	}
6ad2962f8adfd5 Edward Cree    2024-06-27  11994  	xa_destroy(&dev->ethtool->rss_ctx);
87925151191b64 Edward Cree    2024-06-27  11995  	mutex_unlock(&dev->ethtool->rss_lock);
6ad2962f8adfd5 Edward Cree    2024-06-27  11996  }
6ad2962f8adfd5 Edward Cree    2024-06-27  11997  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki