netdev - Re: [PATCH v3 bpf-next 10/12] selftests/bpf: Create established sockets in socket iterator tests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aGLb1ytEc0vi0ndw@mini-arch>
Date: Mon, 30 Jun 2025 11:47:51 -0700
From: Stanislav Fomichev <stfomichev@...il.com>
To: Jordan Rife <jordan@...fe.io>
Cc: netdev@...r.kernel.org, bpf@...r.kernel.org,
	Daniel Borkmann <daniel@...earbox.net>,
	Martin KaFai Lau <martin.lau@...ux.dev>,
	Willem de Bruijn <willemdebruijn.kernel@...il.com>,
	Kuniyuki Iwashima <kuniyu@...gle.com>,
	Alexei Starovoitov <alexei.starovoitov@...il.com>
Subject: Re: [PATCH v3 bpf-next 10/12] selftests/bpf: Create established
 sockets in socket iterator tests

On 06/30, Jordan Rife wrote:
> Prepare for bucket resume tests for established TCP sockets by creating
> established sockets. Collect socket fds from connect() and accept()
> sides and pass them to test cases.
> 
> Signed-off-by: Jordan Rife <jordan@...fe.io>
> ---
>  .../bpf/prog_tests/sock_iter_batch.c          | 83 ++++++++++++++++++-
>  1 file changed, 79 insertions(+), 4 deletions(-)
> 
> diff --git a/tools/testing/selftests/bpf/prog_tests/sock_iter_batch.c b/tools/testing/selftests/bpf/prog_tests/sock_iter_batch.c
> index 4c145c5415f1..2b0504cb127b 100644
> --- a/tools/testing/selftests/bpf/prog_tests/sock_iter_batch.c
> +++ b/tools/testing/selftests/bpf/prog_tests/sock_iter_batch.c
> @@ -153,8 +153,66 @@ static void check_n_were_seen_once(int *fds, int fds_len, int n,
>  	ASSERT_EQ(seen_once, n, "seen_once");
>  }
>  
> +static int accept_from_one(int *server_fds, int server_fds_len)
> +{
> +	int i = 0;
> +	int fd;
> +

[..]

> +	for (; i < server_fds_len; i++) {

nit: move i=0 here?