netdev - Re: [Intel-wired-lan] [PATCH v4 2/2] e1000e: ignore uninitialized checksum word on tgp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5e880e1c-2ee0-22e7-8bcf-3ab35280db47@intel.com>
Date: Tue, 1 Jul 2025 11:58:29 +0300
From: "Lifshits, Vitaly" <vitaly.lifshits@...el.com>
To: Simon Horman <horms@...nel.org>, Jacek Kowalski <jacek@...ekk.info>
CC: Tony Nguyen <anthony.l.nguyen@...el.com>, Przemek Kitszel
	<przemyslaw.kitszel@...el.com>, Andrew Lunn <andrew+netdev@...n.ch>, "David
 S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, "Jakub
 Kicinski" <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Vlad URSU
	<vlad@...u.me>, <intel-wired-lan@...ts.osuosl.org>, <netdev@...r.kernel.org>
Subject: Re: [Intel-wired-lan] [PATCH v4 2/2] e1000e: ignore uninitialized
 checksum word on tgp

On 6/30/2025 8:00 PM, Simon Horman wrote:
> On Mon, Jun 30, 2025 at 10:35:00AM +0200, Jacek Kowalski wrote:
>> As described by Vitaly Lifshits:
>>
>>> Starting from Tiger Lake, LAN NVM is locked for writes by SW, so the
>>> driver cannot perform checksum validation and correction. This means
>>> that all NVM images must leave the factory with correct checksum and
>>> checksum valid bit set.
>>
>> Unfortunately some systems have left the factory with an uninitialized
>> value of 0xFFFF at register address 0x3F (checksum word location).
>> So on Tiger Lake platform we ignore the computed checksum when such
>> condition is encountered.
>>
>> Signed-off-by: Jacek Kowalski <Jacek@...ekk.info>
>> Tested-by: Vlad URSU <vlad@...u.me>
>> Fixes: 4051f68318ca9 ("e1000e: Do not take care about recovery NVM checksum")
>> Cc: stable@...r.kernel.org
> 
> Thanks for the update.
> 
> Reviewed-by: Simon Horman <horms@...nel.org>
> 


Reviewed-by: Vitaly Lifshits <vitaly.lifshits@...el.com>