netdev - Re: [Intel-wired-lan] [PATCH v4 1/2] e1000e: disregard NVM checksum on tgp when valid checksum bit is not set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <344e825a-566c-4f00-8c57-21b351cbe63d@intel.com>
Date: Sun, 13 Jul 2025 14:55:11 +0300
From: Mor Bar-Gabay <morx.bar.gabay@...el.com>
To: Jacek Kowalski <jacek@...ekk.info>, Tony Nguyen
	<anthony.l.nguyen@...el.com>, Przemek Kitszel <przemyslaw.kitszel@...el.com>,
	Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, "Paolo
 Abeni" <pabeni@...hat.com>, Simon Horman <horms@...nel.org>
CC: <intel-wired-lan@...ts.osuosl.org>, <netdev@...r.kernel.org>
Subject: Re: [Intel-wired-lan] [PATCH v4 1/2] e1000e: disregard NVM checksum
 on tgp when valid checksum bit is not set

On 30/06/2025 11:33, Jacek Kowalski wrote:
> As described by Vitaly Lifshits:
> 
>> Starting from Tiger Lake, LAN NVM is locked for writes by SW, so the
>> driver cannot perform checksum validation and correction. This means
>> that all NVM images must leave the factory with correct checksum and
>> checksum valid bit set. Since Tiger Lake devices were the first to have
>> this lock, some systems in the field did not meet this requirement.
>> Therefore, for these transitional devices we skip checksum update and
>> verification, if the valid bit is not set.
> 
> Signed-off-by: Jacek Kowalski <Jacek@...ekk.info>
> Reviewed-by: Simon Horman <horms@...nel.org>
> Reviewed-by: Vitaly Lifshits <vitaly.lifshits@...el.com>
> Fixes: 4051f68318ca9 ("e1000e: Do not take care about recovery NVM checksum")
> Cc: stable@...r.kernel.org
> ---
>   drivers/net/ethernet/intel/e1000e/ich8lan.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
Tested-by: Mor Bar-Gabay <morx.bar.gabay@...el.com>