netdev - Re: [Intel-wired-lan] [PATCH v4 2/2] e1000e: ignore uninitialized checksum word on tgp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0bcccd8b-a76b-484c-bb04-83dc6787c64f@intel.com>
Date: Sun, 20 Jul 2025 10:12:36 +0300
From: Mor Bar-Gabay <morx.bar.gabay@...el.com>
To: Jacek Kowalski <jacek@...ekk.info>, Tony Nguyen
	<anthony.l.nguyen@...el.com>, Przemek Kitszel <przemyslaw.kitszel@...el.com>,
	Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, "Paolo
 Abeni" <pabeni@...hat.com>, Simon Horman <horms@...nel.org>, Vlad URSU
	<vlad@...u.me>
CC: <intel-wired-lan@...ts.osuosl.org>, <netdev@...r.kernel.org>
Subject: Re: [Intel-wired-lan] [PATCH v4 2/2] e1000e: ignore uninitialized
 checksum word on tgp

On 30/06/2025 11:35, Jacek Kowalski wrote:
> As described by Vitaly Lifshits:
> 
>> Starting from Tiger Lake, LAN NVM is locked for writes by SW, so the
>> driver cannot perform checksum validation and correction. This means
>> that all NVM images must leave the factory with correct checksum and
>> checksum valid bit set.
> 
> Unfortunately some systems have left the factory with an uninitialized
> value of 0xFFFF at register address 0x3F (checksum word location).
> So on Tiger Lake platform we ignore the computed checksum when such
> condition is encountered.
> 
> Signed-off-by: Jacek Kowalski <Jacek@...ekk.info>
> Tested-by: Vlad URSU <vlad@...u.me>
> Fixes: 4051f68318ca9 ("e1000e: Do not take care about recovery NVM checksum")
> Cc: stable@...r.kernel.org
> Reviewed-by: Simon Horman <horms@...nel.org>
> Reviewed-by: Vitaly Lifshits <vitaly.lifshits@...el.com>
> ---
>   drivers/net/ethernet/intel/e1000e/defines.h | 3 +++
>   drivers/net/ethernet/intel/e1000e/nvm.c     | 6 ++++++
>   2 files changed, 9 insertions(+)
> 
Tested-by: Mor Bar-Gabay <morx.bar.gabay@...el.com>