netdev - Re: [PATCH net] bnxt_en: eliminate the compile warning in bnxt_request_irq due to CONFIG_RFS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAL+tcoA8+gGaOhAC4p743Ah9fVbmVwk8AT8zHH7SpFr2-pmm=A@mail.gmail.com>
Date: Wed, 2 Jul 2025 09:11:35 +0800
From: Jason Xing <kerneljasonxing@...il.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Simon Horman <horms@...nel.org>, davem@...emloft.net, edumazet@...gle.com, 
	pabeni@...hat.com, andrew+netdev@...n.ch, michael.chan@...adcom.com, 
	pavan.chebbi@...adcom.com, netdev@...r.kernel.org, 
	Jason Xing <kernelxing@...cent.com>, kernel test robot <lkp@...el.com>
Subject: Re: [PATCH net] bnxt_en: eliminate the compile warning in
 bnxt_request_irq due to CONFIG_RFS_ACCEL

On Wed, Jul 2, 2025 at 9:07 AM Jason Xing <kerneljasonxing@...il.com> wrote:
>
> On Wed, Jul 2, 2025 at 8:56 AM Jakub Kicinski <kuba@...nel.org> wrote:
> >
> > On Wed, 2 Jul 2025 08:47:08 +0800 Jason Xing wrote:
> > > >  static int bnxt_request_irq(struct bnxt *bp)
> > > >  {
> > > > +       struct cpu_rmap *rmap = NULL;
> > > >         int i, j, rc = 0;
> > > >         unsigned long flags = 0;
> > > > -#ifdef CONFIG_RFS_ACCEL
> > > > -       struct cpu_rmap *rmap;
> > > > -#endif
> > >
> > > Sorry, Jakub. I failed to see the positive point of this kind of
> > > change comparatively.
> >
> > Like Simon said -- fewer #ifdefs leads to fewer bugs of this nature.
>
> Agree on this point.
>
> > Or do you mean that you don't understand how my fix works?

Oh, thanks to the word 'fix' you mentioned. It seems that I'm supposed
to add Fixes: tag...