netdev - Re: [PATCH net] bnxt_en: eliminate the compile warning in bnxt_request_irq due to CONFIG_RFS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250701183427.497e5f24@kernel.org>
Date: Tue, 1 Jul 2025 18:34:27 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Jason Xing <kerneljasonxing@...il.com>
Cc: Simon Horman <horms@...nel.org>, davem@...emloft.net,
 edumazet@...gle.com, pabeni@...hat.com, andrew+netdev@...n.ch,
 michael.chan@...adcom.com, pavan.chebbi@...adcom.com,
 netdev@...r.kernel.org, Jason Xing <kernelxing@...cent.com>, kernel test
 robot <lkp@...el.com>
Subject: Re: [PATCH net] bnxt_en: eliminate the compile warning in
 bnxt_request_irq due to CONFIG_RFS_ACCEL

On Wed, 2 Jul 2025 09:11:35 +0800 Jason Xing wrote:
> > >
> > > Like Simon said -- fewer #ifdefs leads to fewer bugs of this nature.  
> >
> > Agree on this point.
> >  
> > > Or do you mean that you don't understand how my fix works?  
> 
> Oh, thanks to the word 'fix' you mentioned. It seems that I'm supposed
> to add Fixes: tag...

Yes, change the commit reference to a full Fixes tag.
Also -- may be worth mentioning that it happens with GCC specifically.
My first try to reproduce was with clang and it seems not to show this 
warning even with W=1