netdev - Re: [PATCH v2 net-next] selftests: devmem: configure HDS threshold

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMArcTVYyGWAY0B1mem2nosQk1sJsg5nq9Uz5qB-wa7MFsqt7g@mail.gmail.com>
Date: Thu, 3 Jul 2025 01:12:33 +0900
From: Taehee Yoo <ap420073@...il.com>
To: Stanislav Fomichev <stfomichev@...il.com>
Cc: davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com, 
	edumazet@...gle.com, andrew+netdev@...n.ch, shuah@...nel.org, 
	almasrymina@...gle.com, sdf@...ichev.me, jdamato@...tly.com, 
	netdev@...r.kernel.org, linux-kselftest@...r.kernel.org
Subject: Re: [PATCH v2 net-next] selftests: devmem: configure HDS threshold

On Thu, Jul 3, 2025 at 12:37 AM Stanislav Fomichev <stfomichev@...il.com> wrote:
>

Hi Stanislav,
Thanks a lot for your review!

> On 07/02, Taehee Yoo wrote:
> > The devmem TCP requires the hds-thresh value to be 0, but it doesn't
> > change it automatically.
> > Therefore, make configure_headersplit() sets hds-thresh value to 0.
> >
> > Signed-off-by: Taehee Yoo <ap420073@...il.com>
> > ---
> >
> > v2:
> >  - Do not implement configure_hds_thresh().
> >  - Make configure_headersplit() sets hds-thresh to 0.
> >
> >  tools/testing/selftests/drivers/net/hw/ncdevmem.c | 11 ++++++++++-
> >  1 file changed, 10 insertions(+), 1 deletion(-)
> >
> > diff --git a/tools/testing/selftests/drivers/net/hw/ncdevmem.c b/tools/testing/selftests/drivers/net/hw/ncdevmem.c
> > index cc9b40d9c5d5..52b72de11e3b 100644
> > --- a/tools/testing/selftests/drivers/net/hw/ncdevmem.c
> > +++ b/tools/testing/selftests/drivers/net/hw/ncdevmem.c
> > @@ -331,6 +331,12 @@ static int configure_headersplit(bool on)
> >       ret = ethtool_rings_set(ys, req);
> >       if (ret < 0)
> >               fprintf(stderr, "YNL failed: %s\n", ys->err.msg);
> > +     if (on) {
> > +             ethtool_rings_set_req_set_hds_thresh(req, 0);
> > +             ret = ethtool_rings_set(ys, req);
>
> Why call ethtool_rings_set again here? Can we move ethtool_rings_set_req_set_hds_thresh
> to be after ethtool_rings_set_req_set_tcp_data_split ?

I think tcp-data-split will fail if a driver doesn't support
hds-thresh, even if it supports tcp-data-split.
So, I separated them.