netdev - Re: [PATCH v2 net-next] selftests: devmem: configure HDS threshold

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250702113930.79a9f060@kernel.org>
Date: Wed, 2 Jul 2025 11:39:30 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Taehee Yoo <ap420073@...il.com>
Cc: davem@...emloft.net, pabeni@...hat.com, edumazet@...gle.com,
 andrew+netdev@...n.ch, shuah@...nel.org, almasrymina@...gle.com,
 sdf@...ichev.me, jdamato@...tly.com, netdev@...r.kernel.org,
 linux-kselftest@...r.kernel.org
Subject: Re: [PATCH v2 net-next] selftests: devmem: configure HDS threshold

On Wed,  2 Jul 2025 10:42:49 +0000 Taehee Yoo wrote:
> The devmem TCP requires the hds-thresh value to be 0, but it doesn't
> change it automatically.
> Therefore, make configure_headersplit() sets hds-thresh value to 0.

I don't see any undoing of the configuration :(
The selftest should leave the system in the state that it started.
We should either add some code to undo at shutdown or (preferably)
move the logic to the Python script where we can handle this more
cleanly with defer().
-- 
pw-bot: cr