netdev - Re: [PATCH net-next 3/3] net: phylink: add phylink_sfp_select_interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKgT0UcWGH14B0zZnpHeJKw+5VU96LHFR1vR4CXVjqM10iBJSg@mail.gmail.com>
Date: Wed, 2 Jul 2025 11:07:52 -0700
From: Alexander Duyck <alexander.duyck@...il.com>
To: "Russell King (Oracle)" <linux@...linux.org.uk>
Cc: Maxime Chevallier <maxime.chevallier@...tlin.com>, Andrew Lunn <andrew@...n.ch>, 
	Heiner Kallweit <hkallweit1@...il.com>, "David S. Miller" <davem@...emloft.net>, 
	Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org, 
	Paolo Abeni <pabeni@...hat.com>
Subject: Re: [PATCH net-next 3/3] net: phylink: add phylink_sfp_select_interface_speed()

On Wed, Jul 2, 2025 at 6:37 AM Russell King (Oracle)
<linux@...linux.org.uk> wrote:
>
> On Wed, Jul 02, 2025 at 03:14:26PM +0200, Maxime Chevallier wrote:
> > On Wed, 02 Jul 2025 10:44:34 +0100
> > "Russell King (Oracle)" <rmk+kernel@...linux.org.uk> wrote:
> >
> > > Add phylink_sfp_select_interface_speed() which attempts to select the
> > > SFP interface based on the ethtool speed when autoneg is turned off.
> > > This allows users to turn off autoneg for SFPs that support multiple
> > > interface modes, and have an appropriate interface mode selected.
> > >
> > > Signed-off-by: Russell King (Oracle) <rmk+kernel@...linux.org.uk>
> >
> > Reviewed-by: Maxime Chevallier <maxime.chevallier@...tlin.com>
> >
> > I don't have any hardware to perform relevant tests on this :(
>
> Me neither, I should've said. I'd like to see a t-b from
> Alexander Duyck who originally had the problem before this is
> merged.

It will probably be several days before I can get around to testing it
since I am slammed with meetings most of the next two days, then have
a holiday weekend coming up. I will need to rebase the patches I had
that add support for SFF-8636 and the QSFP support for fbnic before I
can get to testing it. As such you can probably look at having this
pulled in and I will try to get it tested next week.

To add a bit of complexity to all this I am looking at reworking the
fbnic driver to probably add a phydev or some type of c45 swphy to
handle the PMA/PMD (serdes PHY) and AN which is mostly handled by the
firmware which provides the advertised link config. The main reason
for doing this is that the PMD has a 4 second training window that the
firmware kicks in after the link comes up, and I need to essentially
do an "&=" on the link state to keep the PCS from reporting the link
up while training is causing the link to flap.