netdev - Re: [PATCH net-next 3/3] net: phylink: add phylink_sfp_select_interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aGWF5Wee3vfoFtMj@shell.armlinux.org.uk>
Date: Wed, 2 Jul 2025 20:17:57 +0100
From: "Russell King (Oracle)" <linux@...linux.org.uk>
To: Alexander Duyck <alexander.duyck@...il.com>
Cc: Maxime Chevallier <maxime.chevallier@...tlin.com>,
	Andrew Lunn <andrew@...n.ch>,
	Heiner Kallweit <hkallweit1@...il.com>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org,
	Paolo Abeni <pabeni@...hat.com>
Subject: Re: [PATCH net-next 3/3] net: phylink: add
 phylink_sfp_select_interface_speed()

On Wed, Jul 02, 2025 at 11:07:52AM -0700, Alexander Duyck wrote:
> On Wed, Jul 2, 2025 at 6:37 AM Russell King (Oracle)
> <linux@...linux.org.uk> wrote:
> >
> > On Wed, Jul 02, 2025 at 03:14:26PM +0200, Maxime Chevallier wrote:
> > > On Wed, 02 Jul 2025 10:44:34 +0100
> > > "Russell King (Oracle)" <rmk+kernel@...linux.org.uk> wrote:
> > >
> > > > Add phylink_sfp_select_interface_speed() which attempts to select the
> > > > SFP interface based on the ethtool speed when autoneg is turned off.
> > > > This allows users to turn off autoneg for SFPs that support multiple
> > > > interface modes, and have an appropriate interface mode selected.
> > > >
> > > > Signed-off-by: Russell King (Oracle) <rmk+kernel@...linux.org.uk>
> > >
> > > Reviewed-by: Maxime Chevallier <maxime.chevallier@...tlin.com>
> > >
> > > I don't have any hardware to perform relevant tests on this :(
> >
> > Me neither, I should've said. I'd like to see a t-b from
> > Alexander Duyck who originally had the problem before this is
> > merged.
> 
> It will probably be several days before I can get around to testing it
> since I am slammed with meetings most of the next two days, then have
> a holiday weekend coming up.

I, too, have a vacation - from tomorrow for three weeks. I may dip in
and out of kernel emails during that period, but it depends what
happens each day.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!