netdev - Re: [PATCH net-next v2 5/5] net: ethtool: reduce indent for _rxfh

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <06ad8469-56c0-4558-b214-232050143148@gmail.com>
Date: Wed, 2 Jul 2025 19:57:54 +0100
From: Edward Cree <ecree.xilinx@...il.com>
To: Jakub Kicinski <kuba@...nel.org>, davem@...emloft.net
Cc: netdev@...r.kernel.org, edumazet@...gle.com, pabeni@...hat.com,
 andrew+netdev@...n.ch, horms@...nel.org, andrew@...n.ch,
 przemyslaw.kitszel@...el.com, anthony.l.nguyen@...el.com,
 sgoutham@...vell.com, gakula@...vell.com, sbhatta@...vell.com,
 bbhushan2@...vell.com, tariqt@...dia.com, mbloch@...dia.com,
 leon@...nel.org, gal@...dia.com
Subject: Re: [PATCH net-next v2 5/5] net: ethtool: reduce indent for
 _rxfh_context ops

On 02/07/2025 04:06, Jakub Kicinski wrote:
> Now that we don't have the compat code we can reduce the indent
> a little. No functional changes.
> 
> Reviewed-by: Gal Pressman <gal@...dia.com>
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>

Reviewed-by: Edward Cree <ecree.xilinx@...il.com>

...
> +	} else if (create) {
> +		ret = ops->create_rxfh_context(dev, ctx, &rxfh_dev, extack);
> +		/* Make sure driver populates defaults */
> +		WARN_ON_ONCE(!ret && !rxfh_dev.key &&
> +			     ops->rxfh_per_ctx_key &&
> +			     !memchr_inv(ethtool_rxfh_context_key(ctx),
> +					 0, ctx->key_size));

While we're here can we unsplit any of these lines without going over 80?