netdev - Re: [PATCH net-next v3 1/5] eth: otx2: migrate to the *_rxfh

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250708155554.GN452973@horms.kernel.org>
Date: Tue, 8 Jul 2025 16:55:54 +0100
From: Simon Horman <horms@...nel.org>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
	pabeni@...hat.com, andrew+netdev@...n.ch, andrew@...n.ch,
	przemyslaw.kitszel@...el.com, anthony.l.nguyen@...el.com,
	sgoutham@...vell.com, gakula@...vell.com, sbhatta@...vell.com,
	bbhushan2@...vell.com, tariqt@...dia.com, mbloch@...dia.com,
	leon@...nel.org, gal@...dia.com, ecree.xilinx@...il.com
Subject: Re: [PATCH net-next v3 1/5] eth: otx2: migrate to the *_rxfh_context
 ops

On Mon, Jul 07, 2025 at 11:41:11AM -0700, Jakub Kicinski wrote:
> otx2 only supports additional indirection tables (no separate keys
> etc.) so the conversion to dedicated callbacks and core-allocated
> context is mostly removing the code which stores the extra tables
> in the driver. Core already stores the indirection tables for
> additional contexts, and doesn't call .get for them.
> 
> One subtle change here is that we'll now start with the table
> covering all queues, not directing all traffic to queue 0.
> This is what core expects if the user doesn't pass the initial
> indir table explicitly (there's a WARN_ON() in the core trying
> to make sure driver authors don't forget to populate ctx to
> defaults).
> 
> Drivers implementing .create_rxfh_context don't have to set
> cap_rss_ctx_supported, so remove it.
> 
> Tested-by: Geetha Sowjanya <gakula@...vell.com>
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>

Reviewed-by: Simon Horman <horms@...nel.org>