netdev - Re: [PATCH net-next v3 2/5] eth: ice: drop the dead code related to rss

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250708155610.GO452973@horms.kernel.org>
Date: Tue, 8 Jul 2025 16:56:10 +0100
From: Simon Horman <horms@...nel.org>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
	pabeni@...hat.com, andrew+netdev@...n.ch, andrew@...n.ch,
	przemyslaw.kitszel@...el.com, anthony.l.nguyen@...el.com,
	sgoutham@...vell.com, gakula@...vell.com, sbhatta@...vell.com,
	bbhushan2@...vell.com, tariqt@...dia.com, mbloch@...dia.com,
	leon@...nel.org, gal@...dia.com, ecree.xilinx@...il.com
Subject: Re: [PATCH net-next v3 2/5] eth: ice: drop the dead code related to
 rss_contexts

On Mon, Jul 07, 2025 at 11:41:12AM -0700, Jakub Kicinski wrote:
> ICE appears to have some odd form of rss_context use plumbed
> in for .get_rxfh. The .set_rxfh side does not support creating
> contexts, however, so this must be dead code. For at least a year
> now (since commit 7964e7884643 ("net: ethtool: use the tracking
> array for get_rxfh on custom RSS contexts")) we have not been
> calling .get_rxfh with a non-zero rss_context. We just get
> the info from the RSS XArray under dev->ethtool.
> 
> Remove what must be dead code in the driver, clear the support flags.
> 
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>

Reviewed-by: Simon Horman <horms@...nel.org>