netdev - Re: [PATCH net] selftests: drv-net: rss_ctx: Add short delay between per-context traffic checks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6b8c512d-ced5-4116-9dde-fee081fda850@nvidia.com>
Date: Wed, 9 Jul 2025 20:10:14 +0300
From: Nimrod Oren <noren@...dia.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Paolo Abeni <pabeni@...hat.com>, Shuah Khan <shuah@...nel.org>,
 Willem de Bruijn <willemb@...gle.com>, netdev@...r.kernel.org,
 linux-kselftest@...r.kernel.org, Gal Pressman <gal@...dia.com>,
 Carolina Jubran <cjubran@...dia.com>
Subject: Re: [PATCH net] selftests: drv-net: rss_ctx: Add short delay between
 per-context traffic checks

On 02/07/2025 3:23, Jakub Kicinski wrote:
> On Sun, 29 Jun 2025 14:18:12 +0300 Nimrod Oren wrote:
>> A few packets may still be sent and received during the termination of
>> the iperf processes. These late packets cause failures when they arrive
>> on queues expected to be empty.
>>
>> Add a one second delay between repeated _send_traffic_check() calls in
>> rss_ctx tests to ensure such packets are processed before the next
>> traffic checks are performed.
> 
> Sprinklings sleeps should be last resort. Is there a way to wait for
> iperf to shut down cleanly, or wait for the socket to be closed fully?
> Like wait_port_listen() ?

The socket may end up in TIME_WAIT state, so waiting for it to be fully
closed can take ~2 mins. We could opt for a single sleep during
GenerateTraffic.stop(), but that would also affect tests that aren't
impacted by late packets. WDYT?