netdev - Re: [PATCH v3 18/19] net/mlx5e: Add Rx data path offload

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9cda21ef8daef64cc88f2948bff3757d06af3377.camel@nvidia.com>
Date: Fri, 11 Jul 2025 13:01:58 +0000
From: Cosmin Ratiu <cratiu@...dia.com>
To: "corbet@....net" <corbet@....net>, "andrew+netdev@...n.ch"
	<andrew+netdev@...n.ch>, "davem@...emloft.net" <davem@...emloft.net>,
	"kuba@...nel.org" <kuba@...nel.org>, "horms@...nel.org" <horms@...nel.org>,
	"daniel.zahka@...il.com" <daniel.zahka@...il.com>, "edumazet@...gle.com"
	<edumazet@...gle.com>, "donald.hunter@...il.com" <donald.hunter@...il.com>,
	"pabeni@...hat.com" <pabeni@...hat.com>
CC: Boris Pismenny <borisp@...dia.com>, Jianbo Liu <jianbol@...dia.com>,
	"aleksander.lobakin@...el.com" <aleksander.lobakin@...el.com>,
	"kuniyu@...gle.com" <kuniyu@...gle.com>, "leon@...nel.org" <leon@...nel.org>,
	"toke@...hat.com" <toke@...hat.com>, Rahul Rameshbabu
	<rrameshbabu@...dia.com>, "willemb@...gle.com" <willemb@...gle.com>, Raed
 Salem <raeds@...dia.com>, Dragos Tatulea <dtatulea@...dia.com>,
	"ncardwell@...gle.com" <ncardwell@...gle.com>, "dsahern@...nel.org"
	<dsahern@...nel.org>, "sdf@...ichev.me" <sdf@...ichev.me>, Saeed Mahameed
	<saeedm@...dia.com>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>, Tariq
 Toukan <tariqt@...dia.com>, Patrisious Haddad <phaddad@...dia.com>,
	"jacob.e.keller@...el.com" <jacob.e.keller@...el.com>
Subject: Re: [PATCH v3 18/19] net/mlx5e: Add Rx data path offload

On Wed, 2025-07-02 at 10:13 -0700, Daniel Zahka wrote:
> diff --git
> a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/psp_rxtx.h
> b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/psp_rxtx.h
> index 521b2c3620e6..e3cf34bafc24 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/psp_rxtx.h
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/psp_rxtx.h
> @@ -10,6 +10,11 @@
>  #include "en.h"
>  #include "en/txrx.h"
>  
> +/* Bit30: PSP marker, Bit29-23: PSP syndrome, Bit22-0: PSP obj id */
> +#define MLX5_PSP_METADATA_MARKER(metadata)  ((((metadata) >> 30) &
> 0x3) == 0x3)
> +#define MLX5_PSP_METADATA_SYNDROM(metadata) (((metadata) >> 23) &
> GENMASK(6, 0))

Nit: This should be named MLX5_PSP_METADATA_SYNDROME, with an E.

Cosmin.