netdev - Re: [PATCH v3 14/19] net/mlx5e: Implement PSP Tx data path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0272db70126f24a5ba90b7ce918ba0b88cc55b7c.camel@nvidia.com>
Date: Fri, 11 Jul 2025 13:06:15 +0000
From: Cosmin Ratiu <cratiu@...dia.com>
To: "corbet@....net" <corbet@....net>, "andrew+netdev@...n.ch"
	<andrew+netdev@...n.ch>, "davem@...emloft.net" <davem@...emloft.net>,
	"kuba@...nel.org" <kuba@...nel.org>, "horms@...nel.org" <horms@...nel.org>,
	"daniel.zahka@...il.com" <daniel.zahka@...il.com>, "edumazet@...gle.com"
	<edumazet@...gle.com>, "donald.hunter@...il.com" <donald.hunter@...il.com>,
	"pabeni@...hat.com" <pabeni@...hat.com>
CC: Boris Pismenny <borisp@...dia.com>, Jianbo Liu <jianbol@...dia.com>,
	"aleksander.lobakin@...el.com" <aleksander.lobakin@...el.com>,
	"kuniyu@...gle.com" <kuniyu@...gle.com>, "leon@...nel.org" <leon@...nel.org>,
	"toke@...hat.com" <toke@...hat.com>, Rahul Rameshbabu
	<rrameshbabu@...dia.com>, "willemb@...gle.com" <willemb@...gle.com>, Raed
 Salem <raeds@...dia.com>, Dragos Tatulea <dtatulea@...dia.com>,
	"ncardwell@...gle.com" <ncardwell@...gle.com>, "dsahern@...nel.org"
	<dsahern@...nel.org>, "sdf@...ichev.me" <sdf@...ichev.me>, Saeed Mahameed
	<saeedm@...dia.com>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>, Tariq
 Toukan <tariqt@...dia.com>, Patrisious Haddad <phaddad@...dia.com>,
	"jacob.e.keller@...el.com" <jacob.e.keller@...el.com>
Subject: Re: [PATCH v3 14/19] net/mlx5e: Implement PSP Tx data path

On Wed, 2025-07-02 at 10:13 -0700, Daniel Zahka wrote:
> diff --git
> a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/psp_rxtx.c
> b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/psp_rxtx.c
> new file mode 100644
> index 000000000000..e85b5db56fff
> --- /dev/null
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/psp_rxtx.c
[...]
> +static bool mlx5e_psp_set_state(struct mlx5e_priv *priv,
> +				struct sk_buff *skb,
> +				struct mlx5e_accel_tx_psp_state
> *psp_st)
> +{
> +	struct psp_assoc *pas;
> +	bool ret = false;
> +
> +	rcu_read_lock();
> +	pas = psp_skb_get_assoc_rcu(skb);
> +	if (!pas)
> +		goto out;
> +
> +	ret = true;
> +	psp_st->tailen = PSP_TRL_SIZE;
> +	psp_st->spi = pas->tx.spi;
> +	psp_st->ver = pas->version;
> +	memcpy(&psp_st->keyid, pas->drv_data, sizeof(psp_st-
> >keyid));

This should be a simple u32 assignment instead of a memcpy.
So something like:
psp_st->keyid = *(u32*)pas->drv_data;

Cosmin.