netdev - Re: [PATCH net-next v2 2/7] net: airoha: npu: Add NPU wlan memory initialization commands

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <623a647b-806a-4324-9c59-fcad3127f906@kernel.org>
Date: Mon, 14 Jul 2025 09:39:24 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Lorenzo Bianconi <lorenzo@...nel.org>
Cc: Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, linux-arm-kernel@...ts.infradead.org,
 linux-mediatek@...ts.infradead.org, netdev@...r.kernel.org,
 devicetree@...r.kernel.org, Simon Horman <horms@...nel.org>,
 Felix Fietkau <nbd@....name>
Subject: Re: [PATCH net-next v2 2/7] net: airoha: npu: Add NPU wlan memory
 initialization commands

On 08/07/2025 09:33, Lorenzo Bianconi wrote:
> 
>>
>>> posted net-next patches as preliminary ones for MT76 changes).
>>> Moreover, this is the same approach we used when we added WED support to
>>> mtk_eth_soc driver and the related MT76 support.
>>> However, I am fine to post the MT76 changes as RFC and just refer to it in
>>> this series cover-letter. Agree? 
>>>
>>>>
>>>> So far I see ABI break, but without user cannot judge. And that's the
>>>> hard reason this cannot be accepted.
>>>
>>> if you mean the dts changes, I will fix them in v3.
>>>
>> No, I mean driver.
> 
> Sorry, can you please explain what is the ABI break in the driver codebase?
> airoha_npu_wlan_init_memory() is executed by MT76 driver and not during NPU
> probe phase.
> 

Read the first problem I pointed out - no user. Your new ABI returns
error and you changed binding in incompatible way.

Binding change is ABI break and its impact is impossible to judge due to
missing code. I am speaking about this since beginning, but if you keep
insisting that the driver does not matter then this is a NAK because you
change ABI in the binding.

Best regards,
Krzysztof