netdev - Re: [PATCH v13 3/7] i2c: Add Nuvoton NCT6694 I2C support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aHSzvBYwYUpQTAQr@shikoro>
Date: Mon, 14 Jul 2025 09:37:32 +0200
From: Wolfram Sang <wsa+renesas@...g-engineering.com>
To: a0282524688@...il.com
Cc: tmyu0@...oton.com, lee@...nel.org, linus.walleij@...aro.org,
	brgl@...ev.pl, andi.shyti@...nel.org, mkl@...gutronix.de,
	mailhol.vincent@...adoo.fr, andrew+netdev@...n.ch,
	davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
	pabeni@...hat.com, wim@...ux-watchdog.org, linux@...ck-us.net,
	jdelvare@...e.com, alexandre.belloni@...tlin.com,
	linux-kernel@...r.kernel.org, linux-gpio@...r.kernel.org,
	linux-i2c@...r.kernel.org, linux-can@...r.kernel.org,
	netdev@...r.kernel.org, linux-watchdog@...r.kernel.org,
	linux-hwmon@...r.kernel.org, linux-rtc@...r.kernel.org,
	linux-usb@...r.kernel.org
Subject: Re: [PATCH v13 3/7] i2c: Add Nuvoton NCT6694 I2C support


> +		if (msg_temp->len > 64)
> +			return -EPROTO;

Please populate and use 'struct i2c_adapter_quirks' so the I2C core can
handle the checks for you. At least max_read_len and max_write_len. But
please also do check the other flags. Usually, USB adapters have way
more limitations than the buffer size.


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)