netdev - Re: [PATCH v2 1/1] dt-bindings: net: rfkill-gpio: document reset-gpios

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <TY4PR01MB14432A181F668B0FCAACB30139857A@TY4PR01MB14432.jpnprd01.prod.outlook.com>
Date: Tue, 15 Jul 2025 19:29:57 +0800
From: Shengyu Qu <wiagn233@...look.com>
To: Chukun Pan <amadeus@....edu.cn>, Philipp Zabel <p.zabel@...gutronix.de>,
 Johannes Berg <johannes@...solutions.net>
Cc: wiagn233@...look.com, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Rob Herring <robh@...nel.org>,
 devicetree@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH v2 1/1] dt-bindings: net: rfkill-gpio: document
 reset-gpios

Hi everyone,

I have an extra question, what needs to be done if we want to support 
more than one WWAN module? There are some boards that can plug multiple 
WWAN modules, for example Banana Pi R4/R4 Pro.

Best regards,
Shengyu

在 2024/5/28 22:30, Chukun Pan 写道:
> Some 5G WWAN modems have multiple gpio controls. When using rfkill command
> to manage it, we need to at least change the status of reset and shutdown
> gpios at the same time. Also, it might be incorrect to put the reset gpio
> at usb when the module is connected via USB M2 slot, there may be other
> devices connected under some USB node, but the reset gpio is only used for
> the WWAN module. So document the reset-gpios to rfkill-gpio as an optional
> property and add it to a new example.
> 
> For example:
>    - reset: modem Reset#
>    - shutdown: modem WWAN_DISABLE# or FULL_CARD_POWER_OFF#
> 
> Signed-off-by: Chukun Pan <amadeus@....edu.cn>
> ---
>   .../devicetree/bindings/net/rfkill-gpio.yaml       | 14 ++++++++++++++
>   1 file changed, 14 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/rfkill-gpio.yaml b/Documentation/devicetree/bindings/net/rfkill-gpio.yaml
> index 9630c8466fac..7f297efdc976 100644
> --- a/Documentation/devicetree/bindings/net/rfkill-gpio.yaml
> +++ b/Documentation/devicetree/bindings/net/rfkill-gpio.yaml
> @@ -29,6 +29,9 @@ properties:
>         - wlan
>         - wwan
>   
> +  reset-gpios:
> +    maxItems: 1
> +
>     shutdown-gpios:
>       maxItems: 1
>   
> @@ -49,3 +52,14 @@ examples:
>           radio-type = "wlan";
>           shutdown-gpios = <&gpio2 25 GPIO_ACTIVE_HIGH>;
>       };
> +
> +  - | # 5G WWAN modem
> +    #include <dt-bindings/gpio/gpio.h>
> +
> +    rfkill {
> +        compatible = "rfkill-gpio";
> +        label = "rfkill-modem";
> +        radio-type = "wwan";
> +        reset-gpios = <&gpio0 5 GPIO_ACTIVE_HIGH>;
> +        shutdown-gpios = <&gpio0 6 GPIO_ACTIVE_HIGH>;
> +    };


Download attachment "OpenPGP_0xE3520CC91929C8E7.asc" of type "application/pgp-keys" (6869 bytes)

Download attachment "OpenPGP_signature.asc" of type "application/pgp-signature" (841 bytes)