netdev - Re: [PATCH net-next v2 01/11] ethtool: rss: initial RSS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250715073910.4c275711@kernel.org>
Date: Tue, 15 Jul 2025 07:39:10 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Gal Pressman <gal@...dia.com>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
 pabeni@...hat.com, andrew+netdev@...n.ch, horms@...nel.org,
 donald.hunter@...il.com, shuah@...nel.org, kory.maincent@...tlin.com,
 maxime.chevallier@...tlin.com, sdf@...ichev.me, ecree.xilinx@...il.com
Subject: Re: [PATCH net-next v2 01/11] ethtool: rss: initial RSS_SET
 (indirection table handling)

On Tue, 15 Jul 2025 10:20:38 +0300 Gal Pressman wrote:
> > +	rx_rings.cmd = ETHTOOL_GRXRINGS;
> > +	err = ops->get_rxnfc(dev, &rx_rings, NULL);  
> 
> Do we need to check for NULL op?

Hm, yes.

> > +	mutex_lock(&dev->ethtool->rss_lock);
> > +	if (request->rss_context) {
> > +		ctx = xa_load(&dev->ethtool->rss_ctx, request->rss_context);
> > +		if (!ctx) {
> > +			ret = -ENOENT;
> > +			goto exit_unlock;
> > +		}
> > +	}
> > +
> > +	if (!mod)
> > +		ret = 0; /* nothing to tell the driver */
> > +	else if (!ops->set_rxfh)  
> 
> Why not do it in validate?

Because of the silly drivers which only support setting hash fields but
not the RSS basics. We'd need to duplicate the list of which fields end
up fed to ->set_rxfh in validate.