netdev - Re: [PATCH net-next v2 08/11] netlink: specs: define input-xfrm enum in the spec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250715074534.30783870@kernel.org>
Date: Tue, 15 Jul 2025 07:45:34 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Gal Pressman <gal@...dia.com>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
 pabeni@...hat.com, andrew+netdev@...n.ch, horms@...nel.org,
 donald.hunter@...il.com, shuah@...nel.org, kory.maincent@...tlin.com,
 maxime.chevallier@...tlin.com, sdf@...ichev.me, ecree.xilinx@...il.com
Subject: Re: [PATCH net-next v2 08/11] netlink: specs: define input-xfrm
 enum in the spec

On Tue, 15 Jul 2025 11:35:08 +0300 Gal Pressman wrote:
> We kinda use input_xfrm as an enum, but in theory it's a bitmask, so
> while this is OK today, I'm not sure this patch is future-proof.

Yeah, a little unclear at this stage if it's a bitmask or an enum since
we only have values 0 1 2 defined, and the defined values cannot be
composed. Adding an entry that'd compose would be painful if we go with
the string. OTOH I can't think of any composable transform and it's
extra effort to extract the entry form a one-element set each time.

I guess we should go with future-proofness when in doubt. 
I'll make it into flags in v3.