netdev - Re: [PATCH v23 net-next 1/6] sched: Struct definition and parsing of dualpi2 qdisc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250716164547.6d415024@kernel.org>
Date: Wed, 16 Jul 2025 16:45:47 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: chia-yu.chang@...ia-bell-labs.com
Cc: alok.a.tiwari@...cle.com, pctammela@...atatu.com, horms@...nel.org,
 donald.hunter@...il.com, xandfury@...il.com, netdev@...r.kernel.org,
 dave.taht@...il.com, pabeni@...hat.com, jhs@...atatu.com,
 stephen@...workplumber.org, xiyou.wangcong@...il.com, jiri@...nulli.us,
 davem@...emloft.net, edumazet@...gle.com, andrew+netdev@...n.ch,
 ast@...erby.net, liuhangbin@...il.com, shuah@...nel.org,
 linux-kselftest@...r.kernel.org, ij@...nel.org, ncardwell@...gle.com,
 koen.de_schepper@...ia-bell-labs.com, g.white@...lelabs.com,
 ingemar.s.johansson@...csson.com, mirja.kuehlewind@...csson.com,
 cheshire@...le.com, rs.ietf@....at, Jason_Livingood@...cast.com,
 vidhi_goel@...le.com
Subject: Re: [PATCH v23 net-next 1/6] sched: Struct definition and parsing
 of dualpi2 qdisc

On Sun, 13 Jul 2025 12:52:29 +0200 chia-yu.chang@...ia-bell-labs.com
wrote:
> +/* DUALPI2 */
> +enum tc_dualpi2_drop_overload {
> +	TCA_DUALPI2_DROP_OVERLOAD_OVERFLOW = 0,
> +	TCA_DUALPI2_DROP_OVERLOAD_DROP = 1,
> +	__TCA_DUALPI2_DROP_OVERLOAD_MAX,
> +};
> +#define TCA_DUALPI2_DROP_OVERLOAD_MAX (__TCA_DUALPI2_DROP_OVERLOAD_MAX - 1)
> +
> +enum tc_dualpi2_drop_early {
> +	TCA_DUALPI2_DROP_EARLY_DROP_DEQUEUE = 0,
> +	TCA_DUALPI2_DROP_EARLY_DROP_ENQUEUE = 1,
> +	__TCA_DUALPI2_DROP_EARLY_MAX,
> +};
> +#define TCA_DUALPI2_DROP_EARLY_MAX (__TCA_DUALPI2_DROP_EARLY_MAX - 1)
> +
> +enum tc_dualpi2_ecn_mask {
> +	TCA_DUALPI2_ECN_MASK_L4S_ECT = 1,
> +	TCA_DUALPI2_ECN_MASK_CLA_ECT = 2,
> +	TCA_DUALPI2_ECN_MASK_ANY_ECT = 3,
> +	__TCA_DUALPI2_ECN_MASK_MAX,
> +};
> +#define TCA_DUALPI2_ECN_MASK_MAX (__TCA_DUALPI2_ECN_MASK_MAX - 1)
> +
> +enum tc_dualpi2_split_gso {
> +	TCA_DUALPI2_SPLIT_GSO_NO_SPLIT_GSO = 0,
> +	TCA_DUALPI2_SPLIT_GSO_SPLIT_GSO = 1,
> +	__TCA_DUALPI2_SPLIT_GSO_MAX,
> +};
> +#define TCA_DUALPI2_SPLIT_GSO_MAX (__TCA_DUALPI2_SPLIT_GSO_MAX - 1)

Looks like you fixed the type name but not the entry names :(
Once again, TCA_ stands for TC Attribute. These are not attribute IDs
but values. YNL will expect them to be prefixed with TC_DUALPI2,
for example:

static const char * const tc_dualpi2_ecn_mask_strmap[] = {
	[TC_DUALPI2_ECN_MASK_L4S_ECT] = "l4s-ect",
	[TC_DUALPI2_ECN_MASK_CLA_ECT] = "cla-ect",
	[TC_DUALPI2_ECN_MASK_ANY_ECT] = "any-ect",
};

Only the last enum you're adding in this file, which defines the
attributes IDs should use the TCA_ prefix.
-- 
pw-bot: cr