netdev - Re: [PATCH v2 net-next 08/15] neighbour: Annotate access to struct pneigh

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250715183721.5e574b33@kernel.org>
Date: Tue, 15 Jul 2025 18:37:21 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Kuniyuki Iwashima <kuniyu@...gle.com>
Cc: "David S. Miller" <davem@...emloft.net>, Eric Dumazet
 <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, David Ahern
 <dsahern@...nel.org>, Simon Horman <horms@...nel.org>, Kuniyuki Iwashima
 <kuni1840@...il.com>, netdev@...r.kernel.org
Subject: Re: [PATCH v2 net-next 08/15] neighbour: Annotate access to struct
 pneigh_entry.{flags,protocol}.

On Sat, 12 Jul 2025 20:34:17 +0000 Kuniyuki Iwashima wrote:
> -	if (pn->protocol && nla_put_u8(skb, NDA_PROTOCOL, pn->protocol))
> +	if (pn->protocol && nla_put_u8(skb, NDA_PROTOCOL, READ_ONCE(pn->protocol)))

I don't have a good sense of what's idiomatic for READ_ONCE() but
reading the same member twice in one condition, once with READ_ONCE()
and once without looks a bit funny to me :S
-- 
no real bugs, but I hope at least one of the nit picks is worth
addressing ;) so
pw-bot: cr