netdev - Re: [PATCH v2 net-next 01/15] neighbour: Make neigh_valid_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAAVpQUD6M134pHpERL0eREUXK=7=AcWhog1C7rRwgy5cRA7hbQ@mail.gmail.com>
Date: Tue, 15 Jul 2025 23:45:45 -0700
From: Kuniyuki Iwashima <kuniyu@...gle.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, 
	Paolo Abeni <pabeni@...hat.com>, David Ahern <dsahern@...nel.org>, Simon Horman <horms@...nel.org>, 
	Kuniyuki Iwashima <kuni1840@...il.com>, netdev@...r.kernel.org
Subject: Re: [PATCH v2 net-next 01/15] neighbour: Make neigh_valid_get_req()
 return ndmsg.

On Tue, Jul 15, 2025 at 6:17 PM Jakub Kicinski <kuba@...nel.org> wrote:
>
> On Sat, 12 Jul 2025 20:34:10 +0000 Kuniyuki Iwashima wrote:
> > -             return -EINVAL;
> > +             err = -EINVAL;
> > +             goto err;
> >       }
>
> nit, I guess, but why the jumps?
> You could return ERR_PTR(-EINVAL); directly, lower risk someone will
> forget to set err before jumping?

I guess I tried to avoid repeating ERR_PTR() but agree, actually
it was me who forgot to set err in v1 of the previous series :p