netdev - Re: [PATCH v2 net-next 03/15] neighbour: Allocate skb in neigh

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAAVpQUDmsjJ+5u9YNe3+Z6eck7eafEFzR4DBD=Tu8fi03UcqoQ@mail.gmail.com>
Date: Wed, 16 Jul 2025 00:01:35 -0700
From: Kuniyuki Iwashima <kuniyu@...gle.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, 
	Paolo Abeni <pabeni@...hat.com>, David Ahern <dsahern@...nel.org>, Simon Horman <horms@...nel.org>, 
	Kuniyuki Iwashima <kuni1840@...il.com>, netdev@...r.kernel.org
Subject: Re: [PATCH v2 net-next 03/15] neighbour: Allocate skb in neigh_get().

On Tue, Jul 15, 2025 at 6:23 PM Jakub Kicinski <kuba@...nel.org> wrote:
>
> On Sat, 12 Jul 2025 20:34:12 +0000 Kuniyuki Iwashima wrote:
> > +                     err = -ENOENT;
> > +                     goto err;
>
> nit: maybe name the label ? err_free_skb ?

I think this was not to rename all labels to unlock: later in patch 9,
but unlock or something will look better exactly.

---8<---
 err:
+       rcu_read_unlock();
        kfree_skb(skb);
        return err;
 }
---8<---