netdev - Re: [PATCH v2 net-next 08/15] neighbour: Annotate access to struct pneigh

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAAVpQUAC=hw0h3Cn77rApn9iNme90DX_wz7zqd3xUu+cMB=ELA@mail.gmail.com>
Date: Wed, 16 Jul 2025 00:02:46 -0700
From: Kuniyuki Iwashima <kuniyu@...gle.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, 
	Paolo Abeni <pabeni@...hat.com>, David Ahern <dsahern@...nel.org>, Simon Horman <horms@...nel.org>, 
	Kuniyuki Iwashima <kuni1840@...il.com>, netdev@...r.kernel.org
Subject: Re: [PATCH v2 net-next 08/15] neighbour: Annotate access to struct pneigh_entry.{flags,protocol}.

On Tue, Jul 15, 2025 at 6:37 PM Jakub Kicinski <kuba@...nel.org> wrote:
>
> On Sat, 12 Jul 2025 20:34:17 +0000 Kuniyuki Iwashima wrote:
> > -     if (pn->protocol && nla_put_u8(skb, NDA_PROTOCOL, pn->protocol))
> > +     if (pn->protocol && nla_put_u8(skb, NDA_PROTOCOL, READ_ONCE(pn->protocol)))
>
> I don't have a good sense of what's idiomatic for READ_ONCE() but
> reading the same member twice in one condition, once with READ_ONCE()
> and once without looks a bit funny to me :S

Oh sorry, somehow I forgot to cache it.  Will fix it, thanks!


> --
> no real bugs, but I hope at least one of the nit picks is worth
> addressing ;) so
> pw-bot: cr