netdev - Re: [PATCH net-next] net: pcs: xpcs: mask readl() return value to 16 bits

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250716092557.09bc8781@fedora.home>
Date: Wed, 16 Jul 2025 09:25:57 +0200
From: Maxime Chevallier <maxime.chevallier@...tlin.com>
To: Jack Ping CHNG <jchng@...linear.com>
Cc: <netdev@...r.kernel.org>, <davem@...emloft.net>,
 <fancer.lancer@...il.com>, <yzhu@...linear.com>,
 <sureshnagaraj@...linear.com>
Subject: Re: [PATCH net-next] net: pcs: xpcs: mask readl() return value to
 16 bits

Hi Jack,

On Wed, 16 Jul 2025 11:03:49 +0800
Jack Ping CHNG <jchng@...linear.com> wrote:

> readl() returns 32-bit value but Clause 22/45 registers are 16-bit wide.
> Masking with 0xFFFF avoids using garbage upper bits.
> 
> Signed-off-by: Jack Ping CHNG <jchng@...linear.com>

I'm OK with the patch, but is it fixing an issue you've seen in real
life ? If so, you should make this a fix, sent to -net with a Fixes
tag. If not,

Reviewed-by: Maxime Chevallier <maxime.chevallier@...tlin.com>

Maxime