| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <d1b673c0-f2be-49e6-bd0b-80e6518e6a6e@nvidia.com> Date: Wed, 16 Jul 2025 10:28:59 +0300 From: Gal Pressman <gal@...dia.com> To: Jakub Kicinski <kuba@...nel.org>, davem@...emloft.net Cc: netdev@...r.kernel.org, edumazet@...gle.com, pabeni@...hat.com, andrew+netdev@...n.ch, horms@...nel.org, donald.hunter@...il.com, shuah@...nel.org, kory.maincent@...tlin.com, maxime.chevallier@...tlin.com, sdf@...ichev.me, ecree.xilinx@...il.com, jdamato@...tly.com, andrew@...n.ch Subject: Re: [PATCH net-next v3 10/11] ethtool: rss: support setting flow hashing fields On 16/07/2025 3:03, Jakub Kicinski wrote: > Add support for ETHTOOL_SRXFH (setting hashing fields) in RSS_SET. > > The tricky part is dealing with symmetric hashing. In netlink user > can change the hashing fields and symmetric hash in one request, > in IOCTL the two used to be set via different uAPI requests. > Since fields and hash function config are still separate driver > callbacks - changes to the two are not atomic. Keep things simple > and validate the settings against both pre- and post- change ones. > Meaning that we will reject the config request if user tries > to correct the flow fields and set input_xfrm in one request, > or disables input_xfrm and makes flow fields non-symmetric. > > We can adjust it later if there's a real need. Starting simple feels > right, and potentially partially applying the settings isn't nice, > either. > > Signed-off-by: Jakub Kicinski <kuba@...nel.org> Reviewed-by: Gal Pressman <gal@...dia.com>
Powered by blists - more mailing lists